Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emil olejnik #3

Open
wants to merge 87 commits into
base: main
Choose a base branch
from
Open

Conversation

SquirrelloDev
Copy link

Live site URL: https://frontend-currency-exchange-2023.vercel.app/

App features

  1. Exchanges page displaying the table of exchange rates from table A. Clicking on exchange rate displays a modal with additional information and the last 14 rates
  2. Gold prices page displaying table containing prices from the beginning of the current year to the current date with additional information about daily growth (how much the price increased/decreased according to the previous day).
    The page displays also two charts: gold price history chart and daily growth chart (both with the ability to select timespan of the chart).
  3. Converter page displays a table of available currencies to convert where the user can select up to 5 different currencies to convert (excluding PLN).
    Clicking on currency in "Active currencies" opens a modal, where the user can enter the value to convert. After confirming, in the "Active currencies" table, the user is able to see converted values.
    Selected currencies are saved after reloading thanks to local storage API.

@SquirrelloDev
Copy link
Author

@krisldz Czy mógłbyś dać jakiś feedback do mojego rozwiązania; co należałoby usprawnić, jakie błędy popełniłem?

@krisldz
Copy link
Contributor

krisldz commented May 25, 2023

@SquirrelloDev generalnie kod jest całkiem niezły, możnaby dołożyć memoizację. Głównym problem jest źle działający konwerter walut
Screenshot 2023-05-25 at 16 35 10

1000zł nie wymienimy na 4526 Euro lub ~4200 USD

@SquirrelloDev
Copy link
Author

SquirrelloDev commented May 25, 2023

@krisldz Aaaa, dzięki za informację. Straszne przeoczenie, dałem znaki w nie tej kolejności.
Nie chcę być natarczywy, ale czy mogę prosić o drugą szansę? Za bardzo chciałem dopiąć wszystko na ostatni guzik i popełniłem taką gafę.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants