-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emil olejnik #3
base: main
Are you sure you want to change the base?
Emil olejnik #3
Conversation
# Conflicts: # src/components/Converter/CurrencySelectable.tsx
# Conflicts: # vercel.json
@krisldz Czy mógłbyś dać jakiś feedback do mojego rozwiązania; co należałoby usprawnić, jakie błędy popełniłem? |
@SquirrelloDev generalnie kod jest całkiem niezły, możnaby dołożyć memoizację. Głównym problem jest źle działający konwerter walut 1000zł nie wymienimy na 4526 Euro lub ~4200 USD |
@krisldz Aaaa, dzięki za informację. Straszne przeoczenie, dałem znaki w nie tej kolejności. |
Live site URL: https://frontend-currency-exchange-2023.vercel.app/
App features
The page displays also two charts: gold price history chart and daily growth chart (both with the ability to select timespan of the chart).
Clicking on currency in "Active currencies" opens a modal, where the user can enter the value to convert. After confirming, in the "Active currencies" table, the user is able to see converted values.
Selected currencies are saved after reloading thanks to local storage API.