-
Notifications
You must be signed in to change notification settings - Fork 373
docs: Add article "UCP Translates AP2 Requirements into Reality" #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @mdoeseckle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces new documentation aimed at clarifying the relationship and compatibility between the Universal Checkout Protocol (UCP) and the Agent Payments Protocol (AP2). The added article details how UCP's features, such as its Checkout Object and various mandates, align with and fulfill the requirements of the AP2 specification, thereby providing a comprehensive guide for understanding their interoperability. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new documentation article explaining how the Universal Checkout Protocol (UCP) relates to the Agent Payments Protocol (AP2). The new content is clear and informative. My review includes a few minor suggestions to improve consistency, accuracy, and formatting in the documentation.
|
|
||
| At the center of every UCP checkout session is the | ||
| [**Checkout Object**](https://ucp.dev/specification/ap2-mandates/#step-1-checkout-creation-signing), | ||
| which serves as the functional equivalent of the **AP2 CartMandate**. Both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with other documentation files (like core-concepts.md and specification.md), consider using **CartMandate** instead of **AP2 CartMandate**. The other documents refer to it simply as CartMandate.
| which serves as the functional equivalent of the **AP2 CartMandate**. Both | |
| which serves as the functional equivalent of the **CartMandate**. Both |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This commit adds an article discussing how UCP and AP2 protocols relate to one another.