Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icon, colors object detection #21

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

st-tuanmai
Copy link
Contributor

No description provided.

@PaulTR
Copy link
Collaborator

PaulTR commented Oct 9, 2024

Can you verify the run script for downloading the models? Getting

ptruiz-macbookpro:ios ptruiz$ sh RunScripts/download_models.sh
+++ dirname RunScripts/download_models.sh
++ cd RunScripts
++ pwd

@st-tuanmai
Copy link
Contributor Author

st-tuanmai commented Oct 11, 2024

Screenshot 2024-10-11 at 10 20 54 Hi Paul, I check on my Mac, scripts work correctly. You don't need to run scripts manually, scripts will run automatically when building the app.

@PaulTR
Copy link
Collaborator

PaulTR commented Oct 28, 2024

Screenshot 2024-10-28 at 2 42 57 PM

It also does not work from the IDE. Looking at it, the paths are likely wrong ("TFLite"), and the storage link for the tflite files are incorrect. There should only be efficientdet 0 and 2 and they should come from the ai-edge bucket: https://storage.googleapis.com/ai-edge/interpreter-samples/object_detection/ios/efficientdet_lite0.tflite and https://storage.googleapis.com/ai-edge/interpreter-samples/object_detection/ios/efficientdet_lite2.tflite

Please use image classification download_models.sh as your template.

@st-tuanmai
Copy link
Contributor Author

I tried deleting the model and running it again, it still works fine. I will check again.

@st-tuanmai
Copy link
Contributor Author

Screenshot 2024-11-01 at 23 12 36 The script works fine on my mac.

@PaulTR
Copy link
Collaborator

PaulTR commented Nov 1, 2024

Again, it's still using the wrong model paths, bringing in more models than needed, and I'd like it to follow the same format as the other examples.

@st-tuanmai
Copy link
Contributor Author

Sorry @PaulTR
I missed some messages

@st-tuanmai
Copy link
Contributor Author

Screenshot 2024-11-01 at 23 45 00 The output of the new model is not the same structure as the old model so it cannot be fixed quickly, I will try to fix it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants