Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored iOS Object Detection #218

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Refactored iOS Object Detection #218

merged 2 commits into from
Aug 24, 2023

Conversation

khanhlvg
Copy link
Collaborator

@khanhlvg khanhlvg commented Aug 24, 2023

Description

  • Renamed classes to be more descriptive
  • Fixed broken unit tests after previous refactoring
  • Refactored InferenceConfigManger to make value change notification simpler
  • Removed unused classes

Fixes # (issue)

Checklist

Please ensure the following items are complete before submitting a pull request:

  • My code follows the code style of the project.
  • I have updated the documentation (if applicable).
  • I have added tests to cover my changes.

Type of Change

Please check the relevant option below:

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update (non-breaking change which updates documentation)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@khanhlvg khanhlvg merged commit 2948bbc into main Aug 24, 2023
3 checks passed
palrahul pushed a commit to palrahul/mediapipe that referenced this pull request Sep 27, 2023
…ctor_ios_objc

Refactored iOS Object Detection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant