Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify blendshape graph working based on output_blendshapes setting #5525

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

col-fi
Copy link

@col-fi col-fi commented Jul 10, 2024

We noticed that even when outputFaceBlendshapes in FaceLandmarkerOptions was set to false, the blendshape graph was still running. This update makes sure that the FaceLandmarkerGraph doesn't include the blendshape graph when outputFaceBlendshapes is false.

The performance metrics we checked are as follows:
Devices
PocoF1

outputFaceBlendshapes True False False(remove Graph)
inferenceTime(ms) 5554~6280ms 163~173ms 109~114ms
CPU(%) 32~38 27~38 21~25

S22

outputFaceBlendshapes True False False(remove Graph)
inferenceTime(ms) 2700~2900ms 96~103ms 73~85ms
CPU(%) 40~45 40~48 22~25

iPhone7

outputFaceBlendshapes True False False(remove Graph)
inferenceTime(ms) 62.45-131.39ms 58.50~128.16ms 44.6-88.3ms
CPU(%) 140% 135~138% 138%

@Theo-Y
Copy link

Theo-Y commented Jul 12, 2024

Because of this issue, Web TaskVision is also slower than previous versions in face landmarks. Since the javascript version synchronizes with the graph operation, setting blendshape to false in the output does not make a difference in the computation speed(#4608 ).
Could you please review this PR? @kuaashish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants