Ensure thread pool has at least 2 threads when profiling is enabled #5735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the PROFILING feature is enabled, the profiler relies on the thread pool
for its operations. If the thread pool is configured with only 1 thread, it
can lead to resource contention, preventing the Calculator's Process function
from being scheduled.
This commit ensures that the thread pool size is set to at least 2 threads
when profiling is available, avoiding potential scheduling issues.
Relevant code change:
- Added a check to guarantee `num_threads` is at least 2 under
`MEDIAPIPE_PROFILER_AVAILABLE`.
Fixes potential issues with single-threaded configurations under profiling.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the PROFILING feature is enabled, the profiler relies on the thread pool for its operations. If the thread pool is configured with only 1 thread, it can lead to resource contention, preventing the Calculator's Process function from being scheduled.
This commit ensures that the thread pool size is set to at least 2 threads when profiling is available, avoiding potential scheduling issues.
Relevant code change:
num_threadsis at least 2 underMEDIAPIPE_PROFILER_AVAILABLE.Fixes potential issues with single-threaded configurations under profiling.