Add support for kw_only for chex.dataclass.
#290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_549239639
branch
4 times, most recently
from
b36e648 to
316865d
Compare
copybara-service
bot
force-pushed
the
test_549239639
branch
from
316865d to
bd01ae1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
kw_onlyfor chex.dataclass.In practice, chex.dataclasses is keyword only, but isn't marked as such for
dataclasses, which e.g. prevents doing inheritance across chex.dataclasses with a mix of default and not-defaulted arguments.The feature is a no-op in Python 3.9 and lower because
kw_onlywas added todataclasses.dataclassonly in Python 3.10.