Update chex.assert_type to check concrete types instead of just asserting that the type is a floating/integer sub-type.
#333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_607102995
branch
3 times, most recently
from
65d620f to
b63c512
Compare
…erting that the type is a floating/integer sub-type. Previously, `assert_type` would only check that the input was of the same parent type. For example: ``` x = np.ones((1,), dtype=np.float32) chex.assert_type(x, np.float64) # Succeeds chex.assert_type(x, np.int32) # Fails. ``` Instead, if a concrete dtype is provided we check that the input has the same type. If `float` or `np.floating` is provided, we continue to only assert that the input is the same parent. ``` x = np.ones((1,), dtype=np.float32) chex.assert_type(x, np.float64) # Fails chex.assert_type(x, float) # Succeeds. ``` PiperOrigin-RevId: 609283182
copybara-service
bot
force-pushed
the
test_607102995
branch
from
b63c512 to
fd62ce0
Compare
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
chex.assert_typeto check concrete types instead of just asserting that the type is a floating/integer sub-type.Previously,
assert_typewould only check that the input was of the same parent type. For example:Instead, if a concrete dtype is provided we check that the input has the same type. If
floatornp.floatingis provided, we continue to only assert that the input is the same parent.