Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hk.while_loop carrying state when reserving variable sizes of rng keys. #551

Merged
merged 0 commits into from
Nov 1, 2022

Conversation

copybara-service[bot]
Copy link

Fix hk.while_loop carrying state when reserving variable sizes of rng keys.

This is already correctly handled in cond/scan/..., but we need to standardize
on the amount of keys in the internal state before running the while_loop and
after running each iteration to make sure our in- and output state have the
same structure.

Also, fix an issue with assert_unchanged_state to take into account
rng_after set might be smaller than rng_before set.

@copybara-service copybara-service bot force-pushed the test_484505722 branch 2 times, most recently from 5ff9207 to 61d3379 Compare November 1, 2022 12:26
@copybara-service copybara-service bot closed this Nov 1, 2022
@copybara-service copybara-service bot merged commit 6e602af into main Nov 1, 2022
@copybara-service copybara-service bot deleted the test_484505722 branch November 1, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants