Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonnet's base AbstractModule now requires named arguments (Sonnet v1.6 and Python 3) #19

Merged
merged 1 commit into from
Jul 25, 2017

Conversation

guillaume-chevalier
Copy link
Contributor

To use a recent version of Sonnet, I did changes regarding the new behavior, see: google-deepmind/sonnet@601c4f3

The tests pass, except for two parameterizations of testValues in QuadraticTest of problems_test.py. It looks like floating points rounding errors that are somehow unrelated to my changes:

======================================================================
FAIL: testValues_0 (__main__.QuadraticTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/ubuntu/miniconda/lib/python3.6/site-packages/nose_parameterized/parameterized.py", line 392, in standalone_func
    return func(*(a + p.args), **p.kwargs)
  File "problems_test.py", line 111, in testValues
    self.assertEqual(output, ((w * value) - y)**2)
AssertionError: 24.999998 != 25.0

======================================================================
FAIL: testValues_3 (__main__.QuadraticTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/ubuntu/miniconda/lib/python3.6/site-packages/nose_parameterized/parameterized.py", line 392, in standalone_func
    return func(*(a + p.args), **p.kwargs)
  File "problems_test.py", line 111, in testValues
    self.assertEqual(output, ((w * value) - y)**2)
AssertionError: 288.99997 != 289.0

I tested the changes under:

  • Sonnet v1.6
  • TensorFlow 1.2 (with GPU)
  • Python 3.6.1 (miniconda)
  • Ubuntu 16.04
  • Amazon AWS p2 instance (1 x Tesla K80)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@guillaume-chevalier
Copy link
Contributor Author

I signed it!

@guillaume-chevalier
Copy link
Contributor Author

(To be precise, my current employer signed the corporate CLA, so he added me to a Google Group containing my email to allow me to contribute)

@googlebot
Copy link

CLAs look good, thanks!

@sergomezcol sergomezcol merged commit f3c1a8d into google-deepmind:master Jul 25, 2017
@sergomezcol
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants