Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation to explain how schedules work in optimizers. #399

Closed
rosshemsley opened this issue Aug 23, 2022 Discussed in #390 · 1 comment
Closed

Fix documentation to explain how schedules work in optimizers. #399

rosshemsley opened this issue Aug 23, 2022 Discussed in #390 · 1 comment

Comments

@rosshemsley
Copy link
Collaborator

Discussed in #390

Originally posted by nalzok August 13, 2022
For example, in the documentation for optax.adam, we have

learning_rate (Union[float, Callable[[Union[ndarray, float, int]], Union[ndarray, float, int]]]) – this is a fixed global scaling factor.

I noticed that learning_rate can be a function. How can a function be "a fixed global scaling factor"? What parameters should such a function take, and how does its return value affect the optimization process given that Adam has a learning rate schedule on its own?

copybara-service bot pushed a commit that referenced this issue Feb 5, 2024
The doc was slightly misleading see #399.

PiperOrigin-RevId: 604372850
copybara-service bot pushed a commit that referenced this issue Feb 5, 2024
The doc was slightly misleading see #399.

PiperOrigin-RevId: 604372850
copybara-service bot pushed a commit that referenced this issue Feb 6, 2024
The doc was slightly misleading see #399.

PiperOrigin-RevId: 604372850
copybara-service bot pushed a commit that referenced this issue Feb 6, 2024
The doc was slightly misleading see #399.

PiperOrigin-RevId: 604548137
@vroulet
Copy link
Collaborator

vroulet commented Feb 6, 2024

Done in #778

@vroulet vroulet closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants