Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docstring for hungarian_algorithm. #1102

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Fix docstring for hungarian_algorithm. #1102

merged 1 commit into from
Oct 15, 2024

Conversation

carlosgmartin
Copy link
Contributor

@carlosgmartin carlosgmartin commented Oct 11, 2024 •
edited
Loading

@fabianp
Copy link
Member

fabianp commented Oct 13, 2024

thanks for fixing this, I appreciate the attention to detail 😉 . One minor comment on the one-line summary, otherwise LGTM.

@carlosgmartin carlosgmartin force-pushed the fix_hungarian_algorithm_doc branch from 7bd6a51 to d6988f6 Compare October 13, 2024 16:39
@carlosgmartin
Copy link
Contributor Author

@fabianp Fixed.

fabianp
fabianp approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@fabianp fabianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 🙏🏼 !

@copybara-service copybara-service bot merged commit 9f9b2b9 into google-deepmind:main Oct 15, 2024
8 checks passed
@carlosgmartin carlosgmartin deleted the fix_hungarian_algorithm_doc branch October 15, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianp fabianp fabianp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlosgmartin @fabianp