fix: Coherent dtypes of updates with and without MultiSteps #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test cases check different combinations of parameter and update dtypes.
vroulet
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Very nice, thank you @hlzl !
By curiosity did you check the speed before and after your change?
I think it should be the same but would be good to check just to be sure.
In any case, I'll approve this, thank you for all the effort!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #1039 and discussions with @vroulet a proposed fix such that updates with and without
MultiStepshave the same dtypes independent of howacc_gradsand theinner_opt_statewere initialized.