Warn that in future arguments after the initial (prediction, ground_truth) positional arguments will become keyword-only in optax losses. #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_615023064
branch
from
969ca0b to
05db208
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_615023064
branch
5 times, most recently
from
7095640 to
919ad6b
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_615023064
branch
3 times, most recently
from
adff4d4 to
6a2911d
Compare
…ruth) positional arguments will become keyword-only in optax losses. This is to prevent users from accidentally passing in the wrong order of arguments, and to make interfaces functionally more similar (e.g. after partialling loss-specific hyper-parameters). PiperOrigin-RevId: 617138212
copybara-service
bot
force-pushed
the
test_615023064
branch
from
6a2911d to
ca9c109
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warn that in future arguments after the initial (prediction, ground_truth) positional arguments will become keyword-only in optax losses.
This is to prevent users from accidentally passing in the wrong order of arguments, and to make interfaces functionally more similar (e.g. after partialling loss-specific hyper-parameters).