Revert of #898. #915
Merged
Revert of #898. #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_622904634
branch
from
41084d0 to
62a83cb
Compare
-- f6e8ebb by carlosgmartin <cgmartin@andrew.cmu.edu>: Fix softmax_cross_entropy to handle -inf logits correctly when corresponding label is 0. PiperOrigin-RevId: 622911442
copybara-service
bot
force-pushed
the
test_622904634
branch
from
62a83cb to
aea1d5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert of #898.
Reasons:
Gradients w.r.t. labels are now wrong. Needs to be tackled by a custom jvp (as done in e.g. jax.xlogy).
Will do in another PR with additional tests.