LBFGS solver part 2: implementing linesearch ensuring sufficient decrease and small curvature #981
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LBFGS solver part 2: implementing linesearch ensuring sufficient decrease and small curvature
It is recommended to combine LBFGS with a linesearch procedure that ensures not only sufficient decrease but also small curvature along the chosen update direction. We implement the zoom_linesearch presented by Nocedal and Wright, used as reference linesearch method in scipy.
The user API follows the one of the scale_by_backtracking_linesearch, i.e., (i) it is a GradientTransformExtraArgs that requires access to value, grad and value_fn, (ii) it can be combined with any base GradientTransform, (iii) value and gradient computed during the linesearch can be recycled using the optax.value_and_grad_from_state utility.