Set BgB electron convectivity proportional to diffusivity #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theo-brown
changed the title
jcitrin
approved these changes
Feb 11, 2025
Change-Id: I012f84d73d74e64f80fefbed5d9844d3656407f8
|
Thanks. I'll quickly fix the merge conflict (will need to regenerate the test .nc file) and bring this in now |
Change-Id: I40f2dce1c8a98ef48b9f00fc02f22f7dd06188c9
|
Merged with ec8513d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simulations with the BgB model were showing poor agreement in the shape of the convectivity profiles with similar simulations in other codes.
While JETTO/JINTRAC has quite a complex approach for convectivity (that I have struggled to parse from the source code*), RAPTOR adopts a much more simple method: setting
v_e ∝D_e. In this PR I've switched the TORAX BgB model to use the same method as RAPTOR.* What I had implemented previously in the BgB model was only an additional particle pinch term, rather than the main particle convectivity. This became apparent when comparing the profiles.