Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

float16 #55

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

float16 #55

wants to merge 2 commits into from

Conversation

davek44
Copy link

@davek44 davek44 commented Mar 19, 2016

I have imprecise floating points that I'd like to keep small. I made this change to the torch-hdf5 code, and it seems to work fine. Am I overlooking anything here?

@d11
Copy link
Contributor

d11 commented Mar 21, 2016

Hmm, I'm not sure actually. They will be read into a full-size float tensor, and I don't know without checking how safe the conversion of the small floats into large ones is, the way it is being done here. In the resulting float tensor, do you find the extra bits are set to zero? Or might they be uninitialized?
Also bear in mind that when writing the data out they will still be full floats, so this change prevents hdf5 -> Torch -> hdf5 being the identity map.
Apart from those concerns this seems fine though.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants