Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the AudioLoop module #375

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

dtiberio
Copy link

added the AudioLoop module that implements the code from live_api_starter.py as a Python module that can be imported into other apps.

added the Audiooop module that implements the code from live_api_starter.py as a Python module that can be imported into other apps
Copy link

google-cla bot commented Dec 19, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added the status:awaiting review PR awaiting review from a maintainer label Dec 19, 2024
Copy link
Contributor

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I hadn't see this one.

In the description can you add high-level bulletted list of wha changes you're trying to make.

I made a couple of similar changes in #377, sorry I didn't see this first.

I don't think we want to duplicate this file. If we want to move in this direction we should make the changes in the original file, instead of forking.
Also, any change here should be mirrored in the websockets/ version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:awaiting review PR awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants