Skip to content

Comments

Patch #10628 and #10514 into v0.8.0 preview#10646

Merged
chrstnb merged 3 commits intorelease/v0.8.0-preview.1-pr-10629from
cb/patches
Oct 7, 2025
Merged

Patch #10628 and #10514 into v0.8.0 preview#10646
chrstnb merged 3 commits intorelease/v0.8.0-preview.1-pr-10629from
cb/patches

Conversation

@chrstnb
Copy link
Collaborator

@chrstnb chrstnb commented Oct 7, 2025

TLDR

Dive Deeper

Reviewer Test Plan

Testing Matrix

🍏 🪟 🐧
npm run
npx
Docker
Podman - -
Seatbelt - -

Linked issues / bugs

@chrstnb chrstnb requested review from a team as code owners October 7, 2025 16:18
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @chrstnb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the user experience for managing extensions by unifying the install command's input and providing more flexibility for the new command. It also significantly improves the robustness of archive extraction by migrating from external shell commands to native Node.js libraries, reducing potential platform-specific issues and enhancing overall stability.

Highlights

  • Unified Extension Installation: The gemini extensions install command now accepts a single source argument, which intelligently determines if it's a GitHub URL or a local path, simplifying the command-line interface.
  • Flexible Extension Creation: The gemini extensions new command has been enhanced to allow creating an empty extension directory with a default gemini-extension.json manifest if no template is specified.
  • Improved Archive Extraction: The underlying mechanism for extracting archives (e.g., .tar.gz, .zip) has been updated to use native Node.js libraries (tar and extract-zip) instead of relying on external shell commands, improving cross-platform compatibility and reliability.
  • Dependency Updates: The package-lock.json and packages/cli/package.json files have been updated to include new dependencies such as tar, extract-zip, @types/archiver, and archiver to support the new archive handling logic.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several valuable improvements to the extension management commands. The extensions install command is refactored to use a single source argument for both local paths and git URLs, simplifying its usage. The extensions new command is now more flexible, with the template argument being optional. A significant enhancement is the replacement of external tar and unzip commands with native Node.js libraries, which improves cross-platform compatibility and removes reliance on system-installed tools. The changes are accompanied by corresponding test updates. I have one high-severity suggestion to improve error handling in the install command to make it more robust and user-friendly.

@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Size Change: +143 kB (+0.82%)

Total Size: 17.6 MB

Filename Size Change
./bundle/gemini.js 17.6 MB +143 kB (+0.82%)
ℹ️ View Unchanged
Filename Size
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB
./bundle/sandbox-macos-permissive-open.sb 830 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB

compressed-size-action

@chrstnb chrstnb changed the base branch from release/v0.8.0-preview.1 to release/v0.8.0-preview.1-pr-10629 October 7, 2025 16:23
@chrstnb chrstnb enabled auto-merge (squash) October 7, 2025 16:30
@chrstnb chrstnb merged commit aaca0bf into release/v0.8.0-preview.1-pr-10629 Oct 7, 2025
20 checks passed
@chrstnb chrstnb deleted the cb/patches branch October 7, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants