chore(tests): remove obsolete test for hierarchical memory

[pareshjoshij]

Summary

This PR removes an obsolete, skipped test (it.skip) for hierarchical memory loading in config.test.ts. This test was for functionality that has since been moved into the @google/gemini-cli-core package, making the test redundant and a source of test debt.

Details

The skipped test was identified in issue #13120. Its original purpose was to test the file-system logic for loading global context files. However, this logic now resides in @google/gemini-cli-core, which is correctly mocked in this test suite.

The responsibility of config.test.ts is only to ensure the core loadServerHierarchicalMemory function is called with the correct parameters, which is already verified by the test it('should pass extension context file paths...').

This change simply removes the obsolete test and its related "TODO" comments to keep the test suite clean.

Related Issues

Closes #13120

How to Validate

This is a test-only cleanup. The main validation is to ensure all other tests continue to pass.

1. Pull down the branch.
2. Run the test suite for the CLI package:

   npm test packages/cli/src/config/config.test.ts

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello @pareshjoshij, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the maintainability and clarity of the test suite by removing an outdated test case. The test, originally designed for hierarchical memory loading, became redundant after its core functionality was refactored and moved to a separate package. By eliminating this skipped and no longer relevant test, the PR reduces technical debt and streamlines the testing environment.

Highlights

• Test Removal: An obsolete and skipped test (it.skip) for hierarchical memory loading has been removed from config.test.ts.
• Functionality Relocation: The functionality previously tested by this specific test has been moved to the @google/gemini-cli-core package, rendering the original test redundant.
• Test Suite Cleanup: This removal reduces test debt and cleans up the test suite by eliminating redundant code and associated TODO comments, as identified in issue Tests: Critical test for hierarchical memory loading is skipped #13120.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes an obsolete and skipped test related to hierarchical memory loading. The change is well-justified, as the tested functionality has been moved to a different package. Removing this test debt is a good cleanup that improves the maintainability of the test suite. The change is correct and I approve it.

[pareshjoshij]

Hi @jacob314, when you get a moment, please review this — it’s a small but important cleanup that will help keep the repo consistent. Thanks!”

[pareshjoshij]

Hi @scidomino, thank you for the approval! I noticed the checks are still stuck on 'Awaiting approval.' I think they might need a manual trigger to start running? Thanks!