-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Skills] UX Polishing: Transparent feedback and CLI refinements #15954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @NTaylorMullen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user experience for managing skills within the Gemini CLI by providing more transparent and actionable feedback. It refines the default behavior of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refines the user experience for skill management by improving feedback messages and adjusting CLI defaults. The changes make the tool more transparent by including file paths in status messages and provide context-specific guidance for applying changes (restarting the CLI vs. reloading skills in the interactive UI). The default scope for disabling skills is also thoughtfully changed to project.
The implementation is solid, but I've identified an area of code duplication in the CLI command handlers for enable and disable. I've left a comment with a suggestion to refactor this into a shared utility to improve long-term maintainability. Overall, these are great UX improvements.
52c952e to
875b4cd
Compare
21155a5 to
9362916
Compare
875b4cd to
6ce6c35
Compare
9362916 to
4003eb9
Compare
6ce6c35 to
7bf2886
Compare
4003eb9 to
2c6bf6c
Compare
7bf2886 to
ee0bdf9
Compare
2c6bf6c to
55b00fe
Compare
ee0bdf9 to
5abb5d7
Compare
55b00fe to
b131837
Compare
5abb5d7 to
f6670f4
Compare
b131837 to
f7d9f6a
Compare
f6670f4 to
9c813b5
Compare
f7d9f6a to
78ec51f
Compare
9c813b5 to
b5962f5
Compare
78ec51f to
a9e5d59
Compare
|
Size Change: +580 B (0%) Total Size: 22.3 MB ℹ️ View Unchanged
|
- Change default scope for gemini skills disable from 'user' to 'project'. - Update all feedback to include affected file paths for full transparency. - Implement caller-managed guidance: recommend /skills reload for interactive UI and Restart required for CLI. - Update unit tests to match new descriptive feedback format including file paths. Part of #15327
a9e5d59 to
969a38a
Compare
Summary
Polishes the skill management user experience by providing transparent feedback and refining the CLI command defaults.
Details
gemini skills disableCLI command fromusertoproject(Workspace) to align with common project-specific needs.settings.jsonfiles./skills): Recommends using/skills reload.gemini skills): Recommends a restart.Related Issues
Part of #15327
How to Validate
npx vitest packages/cli/src/ui/commands/skillsCommand.test.ts packages/cli/src/commands/skills/enable.test.ts packages/cli/src/commands/skills/disable.test.tsgemini skills disable <name>and verify it defaults to the project scope and shows the file path./skills enable <name>in the interactive UI and verify it mentions all affected scopes with paths and recommends a reload.Pre-Merge Checklist