-
Notifications
You must be signed in to change notification settings - Fork 10.5k
remove manual string when displaying manual model in the footer #15967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @sehoon38, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the user interface by removing the superfluous 'Manual' label when displaying model names in the footer. This change improves the clarity and conciseness of the model information presented to the user, ensuring a cleaner display without losing essential context. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Size Change: -44 B (0%) Total Size: 22.2 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully removes the 'Manual' prefix from the model display string in the footer. However, a high-severity Terminal Injection vulnerability was identified where the application renders a user-configurable model name to the terminal without sanitization, potentially allowing an attacker to manipulate terminal output. Additionally, there's an opportunity to improve the getDisplayString implementation by reducing code duplication, fixing inconsistencies in model alias handling, and adding a missing test case for one of the model aliases.
Summary
Remove "manual" when displaying manual model in the footer.
Details
Simply display the manual model name. Having Manual in front of the model name is redundant.
Before:


After:
Related Issues
How to Validate
Pre-Merge Checklist