Skip to content

Conversation

@sehoon38
Copy link
Collaborator

@sehoon38 sehoon38 commented Jan 6, 2026

Summary

Remove "manual" when displaying manual model in the footer.

Details

Simply display the manual model name. Having Manual in front of the model name is redundant.

Before:
image
After:
image

Related Issues

How to Validate

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sehoon38, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the user interface by removing the superfluous 'Manual' label when displaying model names in the footer. This change improves the clarity and conciseness of the model information presented to the user, ensuring a cleaner display without losing essential context.

Highlights

  • Footer Model Display: The redundant 'Manual' prefix has been removed from the display of manual model names in the application's footer, making the UI more concise.
  • Model Display Logic: The getDisplayString function in packages/core/src/config/models.ts was updated to directly return the model name or alias without prepending 'Manual (' or appending ')', streamlining how model names are presented.
  • Testing: New unit tests have been added for the getDisplayString function to ensure its correct behavior across various model types and aliases. Existing snapshot tests for the Footer component were also updated to reflect the new display format.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@sehoon38 sehoon38 marked this pull request as ready for review January 6, 2026 03:26
@sehoon38 sehoon38 requested a review from a team as a code owner January 6, 2026 03:26
@sehoon38 sehoon38 enabled auto-merge January 6, 2026 03:26
@sehoon38 sehoon38 changed the title remove manual string when displaying manual model on footer remove manual string when displaying manual model in the footer Jan 6, 2026
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Size Change: -44 B (0%)

Total Size: 22.2 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 22.2 MB -44 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully removes the 'Manual' prefix from the model display string in the footer. However, a high-severity Terminal Injection vulnerability was identified where the application renders a user-configurable model name to the terminal without sanitization, potentially allowing an attacker to manipulate terminal output. Additionally, there's an opportunity to improve the getDisplayString implementation by reducing code duplication, fixing inconsistencies in model alias handling, and adding a missing test case for one of the model aliases.

@sehoon38 sehoon38 added this pull request to the merge queue Jan 6, 2026
Merged via the queue into main with commit cbd2eee Jan 6, 2026
20 checks passed
@sehoon38 sehoon38 deleted the sehoon/cleanup_model branch January 6, 2026 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants