Simplify extension settings command

[chrstnb]

Summary

1. New command configure

• Replaced the settings command with configure.
  • Specific setting: gemini extensions configure <extension> <setting>
  • Extension settings: gemini extensions configure <extension>
  • Global settings (for all extensions): gemini extensions configure
• Scope Support: Added --scope flag to switch between user and workspace configuration.

2. Enhancements

• Workspace visibility: The command now informs you if a setting you are configuring in the user scope is already overridden by a workspace setting.
• Flexible lookup: You can refer to settings by their display name (e.g., api-key) or their environment variable name (e.g., API_KEY).

Details

Related Issues

How to Validate

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello @chrstnb, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors and simplifies the way users manage extension settings within the CLI. By introducing a unified configure command, it streamlines the process of setting up extensions, offering greater flexibility in how settings are applied and providing clearer feedback on their scope and potential overrides. This change aims to improve the user experience for extension configuration.

Highlights

• Command Renaming: The settings command has been replaced by a new configure command, offering more intuitive ways to manage extension settings.
• Flexible Configuration: The new configure command supports configuring specific settings, all settings for a given extension, or interactively configuring all installed extensions.
• Scope Management: A new --scope flag allows users to explicitly define whether settings are applied at the user or workspace level.
• Workspace Override Awareness: The command now provides feedback if a user-scoped setting is being configured but is already overridden by a workspace-scoped setting.
• Enhanced Setting Lookup: Settings can now be referenced by either their user-friendly display name (e.g., api-key) or their environment variable name (e.g., API_KEY).
• Comprehensive Testing: A new test file (configure.test.ts) has been added to ensure robust coverage for all new configure command functionalities.
• Build and Lint Fixes: Unused variable errors and any type usage in tests have been resolved to maintain code quality.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the extension settings command by replacing the old settings command with a more flexible configure command. However, a high-severity Path Traversal vulnerability has been identified in the new configure command due to insufficient validation of user-provided input, which could allow a local attacker to read arbitrary files from the filesystem. Additionally, my review highlights areas for improving maintainability, specifically addressing duplicated logic for ExtensionManager creation and enhancing test quality by adding assertions to a test case. These issues should be addressed to ensure robustness and security before merging.

[github-actions]

Size Change: +961 B (0%)

Total Size: 22.2 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	22.2 MB	+961 B (0%)
./bundle/sandbox-macos-permissive-closed.sb	1.03 kB	0 B
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-closed.sb	3.29 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B

_{compressed-size-action}