Skip to content

Conversation

@joshualitt
Copy link
Collaborator

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @joshualitt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to how models are selected for subagents. By allowing subagents to specify "auto" for their model configuration, the system can now dynamically route requests through a ModelRouterService. This enables more intelligent and flexible model selection based on the current context, improving the adaptability and efficiency of agent interactions. The changes involve updates to the agent executor, model configuration service, and various routing strategies to support this new routing capability.

Highlights

  • Subagent Model Routing: Subagents can now leverage model routing by setting their modelConfig.model to "auto", allowing dynamic model selection based on the current context.
  • LocalAgentExecutor Integration: The LocalAgentExecutor has been updated to incorporate the ModelRouterService when an "auto" model is specified for an agent, enabling intelligent model selection.
  • Runtime Model Overrides: The ModelConfigService now supports registering runtime model overrides, which are prioritized during model resolution, offering greater flexibility.
  • RoutingContext Enhancement: The RoutingContext interface has been extended with a requestedModel property to provide more specific context to routing strategies.
  • Routing Strategy Adaptations: All core routing strategies (ClassifierStrategy, FallbackStrategy, OverrideStrategy) have been updated to utilize the requestedModel from the RoutingContext for more precise routing decisions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Size Change: +1.96 kB (+0.01%)

Total Size: 22.2 MB

Filename Size Change
./bundle/gemini.js 22.2 MB +1.96 kB (+0.01%)
ℹ️ View Unchanged
Filename Size
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB
./bundle/sandbox-macos-permissive-open.sb 890 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB

compressed-size-action

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for model routing within subagents by allowing their model to be configured as "auto". When an agent with an "auto" model is executed, the ModelRouterService is invoked to select a concrete model at runtime. The implementation is solid, using runtime model overrides to correctly apply agent-specific generation parameters to the routed model. The LocalAgentExecutor and all routing strategies have been updated to handle this new logic, and the changes are backed by a comprehensive suite of unit tests. The overall design is robust and well-executed.

@gemini-cli gemini-cli bot added status/need-issue Pull requests that need to have an associated issue. and removed status/need-issue Pull requests that need to have an associated issue. labels Jan 7, 2026
@joshualitt joshualitt closed this Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant