-
Notifications
You must be signed in to change notification settings - Fork 10.5k
fix(patch): cherry-pick 788bb04 to release/v0.23.0-preview.5-pr-15817 [CONFLICTS] #16038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # packages/cli/src/ui/hooks/useQuotaAndFallback.ts
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated attempt to integrate a specific commit into a preview release branch, focusing on enhancing the application's model fallback mechanism. It introduces a dedicated function to activate fallback models and logs these events for telemetry, improving the tracking of model usage. However, the automated cherry-pick encountered merge conflicts, necessitating manual intervention to resolve them before the changes can be fully integrated and the next preview release triggered. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a cherry-pick that introduces a new fallback mode. However, the manual merge conflict resolution has left conflict markers in one of the files, which is a critical issue that will break the build. Additionally, a function call was introduced that does not match the existing function signature, which will also cause a compilation error. It appears that some changes from the original pull request were missed during the cherry-pick. Both of these critical issues need to be addressed.
| <<<<<<< HEAD | ||
| config.setModel(proQuotaRequest.fallbackModel); | ||
|
|
||
| ======= | ||
| // The change is not persisted, so the original model is restored on restart. | ||
| config.activateFallbackMode(proQuotaRequest.fallbackModel); | ||
| >>>>>>> 788bb04f5 (log fallback mode (#15817)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unresolved merge conflict markers are present in the code. This will cause a build failure and must be resolved. It appears the intention was to use config.activateFallbackMode.
// The change is not persisted, so the original model is restored on restart.
config.activateFallbackMode(proQuotaRequest.fallbackModel);
packages/core/src/config/config.ts
Outdated
| } | ||
|
|
||
| activateFallbackMode(model: string): void { | ||
| this.setModel(model, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The setModel method is called with two arguments, but its definition only accepts one. This will cause a compilation error. It seems a change to setModel from the original pull request was missed during this cherry-pick. To make the code compile, the second argument can be removed, but the intended logic for temporary model switching will be lost and needs to be properly restored.
| this.setModel(model, true); | |
| this.setModel(model); |
|
Size Change: +255 B (0%) Total Size: 22 MB ℹ️ View Unchanged
|
This PR automatically cherry-picks commit 788bb04 to patch version v0.23.0-preview.5 in the preview release to create version 0.23.0-preview.6.
This cherry-pick resulted in merge conflicts that need manual resolution.
🔧 Next Steps:
📋 Files with conflicts:
The commit has been created with conflict markers for easier manual resolution.
🚨 Important: