feat(cli): show resume message when exiting session#17481
feat(cli): show resume message when exiting session#17481afarber wants to merge 2 commits intogoogle-gemini:mainfrom
Conversation
Summary of ChangesHello @afarber, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a helpful user experience enhancement to the CLI by providing clear instructions on how to resume a session after it has been terminated. By integrating the session ID into the quit process and updating the session summary display, users can now easily pick up where they left off, improving workflow continuity and reducing friction. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a helpful message for resuming a session when the user quits. The implementation is clean and follows existing patterns. I've found one potential issue with a hardcoded command name that might not work in all environments, which I've detailed in a specific comment. Otherwise, the changes look good and the tests are well-written.
|
Hi @jacob314 please review my PR. Here I have tested on Ubuntu 25.04. First I have asked "Which weekday is 1st of Feb", then pressed CTRL-C and finally the
|
1a0b546 to
6a66bab
Compare
|
I am going to close this in favor of the first PR that was opened: #16285 In general we want to foster a positive open-source community. 😄 I am going to help get the first PR opened for this landed. @afarber really appreciate the PR here and the contributions to Gemini CLI. But in the future let's just add a comment on the existing PR like "maybe we should add a test for this" or "what about X edge case?". This way the original PR author can take the feedback and iterate instead of creating a new PR for the same issue. Hope this makes sense, again I love your contributions! |
|
No problem, frankly speaking I noticed the original PR too late when I already started testing my own fix. |

Summary
Display "Resume this session by running
gemini --resume" when quitting via/quitor Ctrl+C, as requested by maintainer in #16226.Details
Add
sessionIdfield toHistoryItemQuittype and pass it through the quit flow:Related Issues
Closes #16226
How to Validate
npm run build && npm run startPre-Merge Checklist