Encourage agent to utilize ecosystem tools to perform work#17881
Encourage agent to utilize ecosystem tools to perform work#17881gundermanc merged 13 commits intomainfrom
Conversation
Summary of ChangesHello @gundermanc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new evaluation test designed to assess the capability of an automated agent to perform code style fixes using external tools. Specifically, it validates whether the agent can correctly invoke Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request introduces a new test case for automated tool use, specifically for ESLint --fix functionality. The test setup correctly defines package.json and .eslintrc.json with rules that are violated by the provided src/file1.js and src/file2.js. The assertion logic accurately verifies that the run_shell_command tool is used with eslint --fix. The changes are well-implemented and serve their intended purpose without introducing any high or critical severity issues.
|
Size Change: +186 B (0%) Total Size: 23.7 MB ℹ️ View Unchanged
|
Summary
Fixes an issue where Gemini CLI attempts to manually perform work that can be better done by a tool. If the tool is part of the project config it often does the right thing already. This change corrects for the scenario where the project doesn't provide a script or the script provided doesn't explicitly pass
--writeor equivalent.Related Issues
Fixes #15032
Pre-Merge Checklist