Show notification when there's a conflict with an extensions command#17890
Show notification when there's a conflict with an extensions command#17890
Conversation
|
Hi @chrstnb, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello @chrstnb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant improvement in user experience by providing clear and concise notifications when command name conflicts arise from installed extensions. It ensures that users are aware of automatic command renaming, enhancing transparency and debugging capabilities within the CLI environment. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Size Change: +2.99 kB (+0.01%) Total Size: 24.3 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
This pull request introduces a notification system to inform users about command conflicts. A potential race condition in the useEffect hook could lead to state updates on an unmounted component, which should be addressed by utilizing the AbortSignal for cancellation, consistent with existing patterns for asynchronous operations.
|
Hi there! Thank you for your contribution to Gemini CLI. We really appreciate the time and effort you've put into this pull request. To keep our backlog manageable and ensure we're focusing on current priorities, we are closing pull requests that haven't seen maintainer activity for 30 days. Currently, the team is prioritizing work associated with 🔒 maintainer only or help wanted issues. If you believe this change is still critical, please feel free to comment with updated details. Otherwise, we encourage contributors to focus on open issues labeled as help wanted. Thank you for your understanding! |
Testing Standards Review (via /review-frontend, reviewed by jacobr)In await new Promise((resolve) => setTimeout(resolve, 100));This violates the project's mandate to avoid fixed waits, as they can lead to flaky and slow tests. Please replace this with the |
jacob314
left a comment
There was a problem hiding this comment.
Looks good overall. Approved once these comments are addressed.
d9d9b89 to
5980464
Compare
fbce060 to
91e0213
Compare

Summary
Add a notification if we rename a command exposed by an extension because of a conflict
Details
Related Issues
Fixes google-gemini/maintainers-gemini-cli#1207
How to Validate
Pre-Merge Checklist