Skip to content

Comments

refactor(config): remove experimental.enableEventDrivenScheduler setting#17924

Merged
abhipatel12 merged 1 commit intomainfrom
abhi/event-tools-cleanup.1
Feb 8, 2026
Merged

refactor(config): remove experimental.enableEventDrivenScheduler setting#17924
abhipatel12 merged 1 commit intomainfrom
abhi/event-tools-cleanup.1

Conversation

@abhipatel12
Copy link
Collaborator

Summary

This PR removes the experimental setting experimental.enableEventDrivenScheduler and sets it to true by default. This is part of a cleanup effort to stabilize the event-driven scheduler as a core feature.

Details

  • Removed enableEventDrivenScheduler from settingsSchema.ts and settings.schema.json.
  • Updated loadCliConfig in config.ts to hardcode enableEventDrivenScheduler to true.
  • Cleaned up related unit tests and regenerated documentation.

Related Issues

Related to cleanup of experimental flags.

How to Validate

  1. Run npm run test to ensure core functionality remains intact.
  2. Verify that experimental.enableEventDrivenScheduler is no longer listed in gemini settings.
  3. Verify that documentation (docs/get-started/configuration.md) has been updated.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run

@abhipatel12 abhipatel12 requested review from a team as code owners January 30, 2026 00:54
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @abhipatel12, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the configuration by removing an experimental flag related to the event-driven scheduler. By hardcoding this feature to be always on, it signifies its graduation from an experimental state to a stable, default component of the system. This change simplifies the configuration surface and ensures consistent behavior across all installations.

Highlights

  • Setting Removal: The experimental.enableEventDrivenScheduler setting has been completely removed from the configuration schema and documentation.
  • Default Behavior: The event-driven scheduler is now enabled by default and hardcoded to true within the CLI configuration loading process, making it a core, non-configurable feature.
  • Code Cleanup: Associated unit tests for the enableEventDrivenScheduler setting have been removed, and documentation has been updated to reflect its removal.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully removes the experimental.enableEventDrivenScheduler setting and hardcodes its value to true, aligning with the goal of stabilizing the event-driven scheduler as a core feature. The changes are consistent across documentation, schema definitions, and configuration loading logic. No high or critical severity issues were found.

@github-actions
Copy link

Size Change: -353 B (0%)

Total Size: 23.5 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 23.5 MB -353 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@gemini-cli gemini-cli bot added the status/need-issue Pull requests that need to have an associated issue. label Jan 30, 2026
Copy link
Member

@gundermanc gundermanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhipatel12 abhipatel12 added this pull request to the merge queue Feb 8, 2026
Merged via the queue into main with commit 3152204 Feb 8, 2026
27 checks passed
@abhipatel12 abhipatel12 deleted the abhi/event-tools-cleanup.1 branch February 8, 2026 04:17
aswinashok44 pushed a commit to aswinashok44/gemini-cli that referenced this pull request Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants