refactor(config): remove experimental.enableEventDrivenScheduler setting#17924
refactor(config): remove experimental.enableEventDrivenScheduler setting#17924abhipatel12 merged 1 commit intomainfrom
Conversation
Summary of ChangesHello @abhipatel12, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the configuration by removing an experimental flag related to the event-driven scheduler. By hardcoding this feature to be always on, it signifies its graduation from an experimental state to a stable, default component of the system. This change simplifies the configuration surface and ensures consistent behavior across all installations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request successfully removes the experimental.enableEventDrivenScheduler setting and hardcodes its value to true, aligning with the goal of stabilizing the event-driven scheduler as a core feature. The changes are consistent across documentation, schema definitions, and configuration loading logic. No high or critical severity issues were found.
|
Size Change: -353 B (0%) Total Size: 23.5 MB ℹ️ View Unchanged
|
Summary
This PR removes the experimental setting
experimental.enableEventDrivenSchedulerand sets it totrueby default. This is part of a cleanup effort to stabilize the event-driven scheduler as a core feature.Details
enableEventDrivenSchedulerfromsettingsSchema.tsandsettings.schema.json.loadCliConfiginconfig.tsto hardcodeenableEventDrivenSchedulertotrue.Related Issues
Related to cleanup of experimental flags.
How to Validate
npm run testto ensure core functionality remains intact.experimental.enableEventDrivenScheduleris no longer listed ingemini settings.docs/get-started/configuration.md) has been updated.Pre-Merge Checklist