feat: increase ask_user label limit to 16 characters

[jackwotherspoon]

Summary

Increase the maximum character length for ask_user tool labels (headers) from 12 to 16 characters.

Details

The previous limit of 12 characters was found to be too restrictive for certain descriptive labels. This PR updates:

• The JSON schema in AskUserTool to allow maxLength: 16.
• The internal description to reflect the new limit.
• The corresponding test expectations in ask-user.test.ts.

Related Issues

Closes #18319

How to Validate

Ask for a question with a 14 or 15 char label.

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello @jackwotherspoon, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the ask_user tool by extending the character limit for its labels, or headers, from 12 to 16 characters. This change provides greater flexibility for users to create more descriptive and informative labels, addressing a previous restriction without impacting the tool's core functionality.

Highlights

• AskUserTool Label Limit Increase: The maximum character length for ask_user tool labels (headers) has been increased from 12 to 16 characters to allow for more descriptive labels.
• JSON Schema Update: The maxLength property for the header field within the AskUserTool's JSON schema has been updated to 16.
• Test Expectations Adjusted: The corresponding test expectations in ask-user.test.ts have been updated to validate against the new 16-character limit.

Changelog

• packages/core/src/tools/ask-user.test.ts
  • Updated the expected error message in validateToolParams to reflect the new 16-character limit for headers.
• packages/core/src/tools/ask-user.ts
  • Modified the maxLength property for the header field in the JSON schema from 12 to 16.
  • Updated the description for the header field to mention the new 16-character maximum.

Activity

• The pull request was created by jackwotherspoon with a clear description and validation steps.
• No further human activity (comments, reviews, etc.) has been recorded since its creation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request increases the maximum character length for ask_user tool labels from 12 to 16. The changes correctly update the tool's JSON schema and the corresponding test case. My feedback includes a suggestion to add a test case that validates the new upper boundary to improve test coverage and robustness.

[github-actions]

Size Change: -2 B (0%)

Total Size: 23.7 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	23.7 MB	-2 B (0%)
./bundle/sandbox-macos-permissive-closed.sb	1.03 kB	0 B
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-closed.sb	3.29 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B

_{compressed-size-action}