Skip to content

fix(hooks): remove unnecessary logging for hook registration#18332

Merged
abhipatel12 merged 1 commit intomainfrom
abhi/hooks/remove-logging-for-registered-hooks
Feb 4, 2026
Merged

fix(hooks): remove unnecessary logging for hook registration#18332
abhipatel12 merged 1 commit intomainfrom
abhi/hooks/remove-logging-for-registered-hooks

Conversation

@abhipatel12
Copy link
Collaborator

removes unneeded hook logging for initial hooks that are registered since this is noisy for non-interactive mode

@abhipatel12 abhipatel12 requested a review from a team as a code owner February 4, 2026 19:28
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @abhipatel12, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to reduce logging verbosity during the initialization of the hook registry. By downgrading a specific log message from a general log level to a debug level, the change prevents unnecessary output in non-interactive modes, making the system's behavior cleaner and less noisy for users who are not actively debugging.

Highlights

  • Logging Verbosity: The logging level for the hook registry initialization message has been changed from log to debug. This reduces noise, especially in non-interactive environments, by ensuring this message only appears when debug logging is explicitly enabled.
  • Test Updates: The corresponding unit test in hookRegistry.test.ts was updated to reflect the change, now asserting that mockDebugLogger.debug is called instead of mockDebugLogger.log.
Changelog
  • packages/core/src/hooks/hookRegistry.test.ts
    • Updated the test expectation to verify mockDebugLogger.debug is called instead of mockDebugLogger.log for the hook registry initialization message.
  • packages/core/src/hooks/hookRegistry.ts
    • Modified the initialize method to use debugLogger.debug instead of debugLogger.log when reporting the number of initialized hook entries.
Activity
  • No human activity (comments, reviews, etc.) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively reduces logging noise during initial hook registration by changing the log level from log to debug. This is a suitable change for messages that are primarily useful during debugging sessions. The test suite has been updated accordingly to reflect this change, ensuring the new behavior is correctly verified. The changes are focused and correctly implement the intended fix.

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

Size Change: 0 B

Total Size: 23.7 MB

ℹ️ View Unchanged
Filename Size
./bundle/gemini.js 23.7 MB
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB
./bundle/sandbox-macos-permissive-open.sb 890 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB

compressed-size-action

@gemini-cli gemini-cli bot added the status/need-issue Pull requests that need to have an associated issue. label Feb 4, 2026
@abhipatel12 abhipatel12 added this pull request to the merge queue Feb 4, 2026
Merged via the queue into main with commit 3afc8f2 Feb 4, 2026
28 checks passed
@abhipatel12 abhipatel12 deleted the abhi/hooks/remove-logging-for-registered-hooks branch February 4, 2026 19:58
sidwan02 pushed a commit to sidwan02/gemini-cli-gemma that referenced this pull request Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants