feat(cli): add WebSocket-based network logging and streaming chunk support#18383
feat(cli): add WebSocket-based network logging and streaming chunk support#18383SandyTao520 merged 6 commits intomainfrom
Conversation
|
Hi @SandyTao520, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
|
Hi there! Thank you for your contribution to Gemini CLI. To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md. This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding How to link an issue: Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello @SandyTao520, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the CLI's activity logging capabilities by integrating WebSocket-based real-time log transmission and enabling detailed streaming of network response chunks. This allows developers to monitor CLI activity and network interactions in external DevTools, improving debugging and observability, especially for long-running or streaming operations. The new system includes robust reconnection and buffering mechanisms to ensure log integrity even during temporary disconnections. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces significant enhancements to activity logging by adding WebSocket support for real-time log transmission and handling of streaming API responses. The implementation includes robust features like log buffering and automatic reconnection for the WebSocket client. My review identifies a critical regression that restricts the activity logger's activation, breaking existing logging functionality for non-interactive sessions. Additionally, I've found a high-severity issue in the new parseHostPort utility function that can lead to incorrect parsing of certain network addresses. I've provided detailed comments and code suggestions to address these issues, ensuring the new features are both powerful and reliable.
|
Size Change: +6.95 kB (+0.03%) Total Size: 23.8 MB
ℹ️ View Unchanged
|
…pport - Add WebSocket client for real-time log transmission to DevTools - Support streaming chunks in fetch API by reading ReadableStream - Add reconnection and buffering logic for network logging - Support environment variable GEMINI_CLI_ACTIVITY_LOG_TARGET for host:port configuration - Add parseHostPort utility function - Enable/disable network logging dynamically
0e4f063 to
6745463
Compare
…ly check config.storage
Summary
Add WebSocket client support to the activity logger for real-time log transmission to external DevTools, and support streaming chunks in the fetch API by reading ReadableStream.
Details
activityLogger.tsfor real-time log transmission to DevToolsReadableStreamfrom fetch API responsesGEMINI_CLI_ACTIVITY_LOG_TARGETenvironment variable for configuringhost:portparseHostPortutility functionwspackage dependencyRelated Issues
#18007
How to Validate
GEMINI_CLI_ACTIVITY_LOG_TARGET=localhost:9100environment variablePre-Merge Checklist