Conversation
Summary of ChangesHello @chrstnb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes the foundational client-side logic for interacting with an external extension registry. It enables the CLI to programmatically access and filter a list of available extensions, which is crucial for supporting future user interface features related to extension discovery and management. The implementation includes robust data retrieval, sorting, and searching capabilities, along with a caching layer for efficiency. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new ExtensionRegistryClient to fetch extensions from a remote JSON file, along with corresponding tests. The implementation is clean and the tests are comprehensive. I've identified two areas for improvement in extensionRegistryClient.ts to enhance robustness and adherence to project conventions:
- The use of the global
fetchAPI should be replaced withfetchWithTimeoutto prevent the application from hanging on slow network requests. - The
switchstatement ingetExtensionsshould include an exhaustive check in itsdefaultcase to ensure all possibleorderByvalues are handled, which aligns with the repository's coding guidelines.
|
Size Change: +167 B (0%) Total Size: 23.8 MB ℹ️ View Unchanged
|
sehoon38
left a comment
There was a problem hiding this comment.
few comments, LGTM overall
Summary
Add a client to be used to fetch extensions from geminicli.com/extensions.json
Details
This may change in the future, but should unblock UI work at the moment.
Related Issues
Fixes https://github.com/google-gemini/maintainers-gemini-cli/issues/1321
How to Validate
Pre-Merge Checklist