fix(cli): reload skills and agents on extension restart#18411
fix(cli): reload skills and agents on extension restart#18411NTaylorMullen merged 2 commits intomainfrom
Conversation
Ensure that running /extensions restart also triggers a reload of agent skills and agents, removing the need for manual /skills reload or /agents refresh commands. Fixes https://github.com/google-gemini/gemini-cli/issues/REPLACE_WITH_ISSUE_NUMBER
Summary of ChangesHello @NTaylorMullen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the command-line interface by automating the reloading of skills and agents whenever an extension restart is performed. This improvement addresses a previous inconvenience where users had to manually trigger these reloads, thereby providing a more seamless and efficient development experience. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly adds functionality to reload skills and agents after an extension restart. However, the new logic for reloading skills and agents lacks error handling. An unhandled exception during this process could prevent the user from seeing the final status of the extension restart operation, leading to a confusing user experience. I've suggested adding a try...catch block to gracefully handle potential errors during the reload process.
|
Size Change: +371 B (0%) Total Size: 23.8 MB ℹ️ View Unchanged
|
|
Thanks @NTaylorMullen |
- Adds try-catch block to reloadSkills and agentRegistry.reload in restartAction - Adds tests to verify error handling when reloading fails
This PR ensures that when extensions are restarted via
/extensions restart, any associated skills and agents are automatically reloaded. Previously, users had to manually run/skills reloadand/agents refreshfor changes to take effect.