Skip to content

Comments

fix(cli): reload skills and agents on extension restart#18411

Merged
NTaylorMullen merged 2 commits intomainfrom
ntm/gh.reload-skills-on-extension-restart
Feb 7, 2026
Merged

fix(cli): reload skills and agents on extension restart#18411
NTaylorMullen merged 2 commits intomainfrom
ntm/gh.reload-skills-on-extension-restart

Conversation

@NTaylorMullen
Copy link
Collaborator

This PR ensures that when extensions are restarted via /extensions restart, any associated skills and agents are automatically reloaded. Previously, users had to manually run /skills reload and /agents refresh for changes to take effect.

Ensure that running /extensions restart also triggers a reload of agent
skills and agents, removing the need for manual /skills reload or
/agents refresh commands.

Fixes https://github.com/google-gemini/gemini-cli/issues/REPLACE_WITH_ISSUE_NUMBER
@NTaylorMullen NTaylorMullen requested a review from a team as a code owner February 6, 2026 01:24
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @NTaylorMullen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the command-line interface by automating the reloading of skills and agents whenever an extension restart is performed. This improvement addresses a previous inconvenience where users had to manually trigger these reloads, thereby providing a more seamless and efficient development experience.

Highlights

  • Automated Skill and Agent Reloading: This pull request introduces automatic reloading of skills and agents when extensions are restarted via the /extensions restart command. This eliminates the need for users to manually run /skills reload and /agents refresh.
  • Improved User Experience: The change streamlines the workflow for developers and users, ensuring that changes related to extensions, skills, and agents are immediately reflected after a restart without additional manual steps.
Changelog
  • packages/cli/src/ui/commands/extensionsCommand.test.ts
    • Added mocks for reloadSkills and getAgentRegistry().reload() within the test setup for extensionsCommand to simulate the new functionality.
  • packages/cli/src/ui/commands/extensionsCommand.ts
    • Implemented calls to context.services.config?.reloadSkills() and context.services.config?.getAgentRegistry()?.reload() within the restartAction function.
    • The reloading logic is conditionally executed only if at least one extension was successfully restarted, preventing unnecessary reloads if all restarts failed.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds functionality to reload skills and agents after an extension restart. However, the new logic for reloading skills and agents lacks error handling. An unhandled exception during this process could prevent the user from seeing the final status of the extension restart operation, leading to a confusing user experience. I've suggested adding a try...catch block to gracefully handle potential errors during the reload process.

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Size Change: +371 B (0%)

Total Size: 23.8 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 23.8 MB +371 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@gemini-cli gemini-cli bot added the status/need-issue Pull requests that need to have an associated issue. label Feb 6, 2026
@MushuEE
Copy link
Contributor

MushuEE commented Feb 6, 2026

Thanks @NTaylorMullen

- Adds try-catch block to reloadSkills and agentRegistry.reload in restartAction
- Adds tests to verify error handling when reloading fails
@NTaylorMullen NTaylorMullen added this pull request to the merge queue Feb 7, 2026
Merged via the queue into main with commit bc9b305 Feb 7, 2026
26 checks passed
@NTaylorMullen NTaylorMullen deleted the ntm/gh.reload-skills-on-extension-restart branch February 7, 2026 00:54
aswinashok44 pushed a commit to aswinashok44/gemini-cli that referenced this pull request Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants