propagate abortSignal

[scidomino]

Summary

Properly propagate abort signal.

Related Issues

For #17135

[gemini-code-assist]

Summary of Changes

Hello @scidomino, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the application's ability to handle cancellation of ongoing operations, specifically for reading Managed Cloud Platform (MCP) resources. By integrating AbortSignal throughout the relevant call paths, it ensures that resource fetching can be gracefully terminated, leading to improved responsiveness and resource management within the CLI's command processing.

Highlights

• AbortSignal Propagation: The readMcpResources function now accepts and correctly propagates an AbortSignal to its underlying client.readResource calls, enabling cancellation of resource fetching operations.
• McpClient Update: The McpClient.readResource method has been updated to accept an optional options object containing an AbortSignal, allowing for the cancellation of network requests.
• Test Coverage: Existing tests for atCommandProcessor have been updated to reflect and verify that readResource is indeed called with the AbortSignal.

Changelog

• packages/cli/src/ui/hooks/atCommandProcessor.test.ts
  • Updated test expectation for readResource to include the signal option, reflecting the new API.
• packages/cli/src/ui/hooks/atCommandProcessor.ts
  • Modified readMcpResources function signature to accept an AbortSignal parameter.
  • Passed the AbortSignal from readMcpResources to the client.readResource call.
  • Updated the handleAtCommand function to pass the signal to readMcpResources.
• packages/core/src/tools/mcp-client.ts
  • Enhanced readResource method to accept an optional options object containing an AbortSignal for request cancellation.

Activity

• No activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Size Change: +54 B (0%)

Total Size: 23.8 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	23.8 MB	+54 B (0%)
./bundle/sandbox-macos-permissive-closed.sb	1.03 kB	0 B
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-closed.sb	3.29 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B

_{compressed-size-action}

[gemini-code-assist]

Code Review

This pull request correctly propagates the AbortSignal through the call chain for reading MCP resources, from handleAtCommand down to the MCP client request. The changes are well-contained and include an updated test to verify the new behavior. This is a good improvement for enabling cancellation of potentially long-running resource reads.