chore: remove redundant planning prompt from final shell#18528
Conversation
This is a follow up to #17263, ensuring consistency between snippets.ts and snippets.legacy.ts by removing the redundant planning section from renderFinalShell.
|
Hi @jerop, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello @jerop, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the prompt generation mechanism by removing a redundant planning prompt section. The primary goal is to achieve greater consistency between different prompt snippet implementations and to streamline the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a nice cleanup that removes a redundant planning prompt from renderFinalShell. By doing so, it brings snippets.ts in line with snippets.legacy.ts, improving consistency across the codebase. The planning prompt logic is now correctly consolidated within the core system prompt generation. The changes are straightforward and represent a good refactoring that removes dead code and improves clarity. I have no further comments.
|
Size Change: -2.69 kB (-0.01%) Total Size: 23.8 MB
ℹ️ View Unchanged
|
This is a follow up to #17263, ensuring consistency between snippets.ts and snippets.legacy.ts by removing the redundant planning section from renderFinalShell.
Related to #16857