Skip to content

Comments

chore: remove redundant planning prompt from final shell#18528

Merged
jerop merged 1 commit intomainfrom
remove-planning-prompt-final-shell
Feb 7, 2026
Merged

chore: remove redundant planning prompt from final shell#18528
jerop merged 1 commit intomainfrom
remove-planning-prompt-final-shell

Conversation

@jerop
Copy link
Contributor

@jerop jerop commented Feb 7, 2026

This is a follow up to #17263, ensuring consistency between snippets.ts and snippets.legacy.ts by removing the redundant planning section from renderFinalShell.

Related to #16857

This is a follow up to #17263, ensuring consistency between snippets.ts and snippets.legacy.ts by removing the redundant planning section from renderFinalShell.
@jerop jerop requested a review from a team as a code owner February 7, 2026 19:37
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Feb 7, 2026

Hi @jerop, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jerop, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the prompt generation mechanism by removing a redundant planning prompt section. The primary goal is to achieve greater consistency between different prompt snippet implementations and to streamline the renderFinalShell function by eliminating an unnecessary parameter and its associated logic. This cleanup simplifies the codebase and ensures a more unified approach to prompt construction.

Highlights

  • Redundant Planning Prompt Removal: The pull request eliminates a redundant planning prompt section from the final shell rendering logic, simplifying the prompt generation process.
  • Consistency Across Snippets: This change ensures consistency between snippets.ts and snippets.legacy.ts by removing the planning prompt from the renderFinalShell function.
  • Code Cleanup: The ApprovalModePlanOptions interface and the renderApprovalModePlan function have been removed, streamlining the prompt generation codebase.
Changelog
  • packages/core/src/prompts/promptProvider.ts
    • The planOptions variable and its initialization logic, which gathered context for planning mode, have been removed.
    • The renderFinalShell function call has been updated to no longer pass the planOptions argument.
  • packages/core/src/prompts/snippets.ts
    • The ApprovalModePlanOptions interface, which defined the structure for planning mode options, has been deleted.
    • The renderFinalShell function's signature has been modified to remove the planOptions parameter.
    • The internal call to renderApprovalModePlan within renderFinalShell has been removed.
    • The renderApprovalModePlan function itself, responsible for rendering the planning mode prompt, has been entirely removed.
Activity
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a nice cleanup that removes a redundant planning prompt from renderFinalShell. By doing so, it brings snippets.ts in line with snippets.legacy.ts, improving consistency across the codebase. The planning prompt logic is now correctly consolidated within the core system prompt generation. The changes are straightforward and represent a good refactoring that removes dead code and improves clarity. I have no further comments.

@github-actions
Copy link

github-actions bot commented Feb 7, 2026

Size Change: -2.69 kB (-0.01%)

Total Size: 23.8 MB

Filename Size Change
./bundle/gemini.js 23.8 MB -2.69 kB (-0.01%)
ℹ️ View Unchanged
Filename Size
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB
./bundle/sandbox-macos-permissive-open.sb 890 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB

compressed-size-action

@gemini-cli gemini-cli bot added the status/need-issue Pull requests that need to have an associated issue. label Feb 7, 2026
@jerop jerop enabled auto-merge February 7, 2026 19:43
@jerop jerop added this pull request to the merge queue Feb 7, 2026
Merged via the queue into main with commit be6723e Feb 7, 2026
28 checks passed
@jerop jerop deleted the remove-planning-prompt-final-shell branch February 7, 2026 19:51
aswinashok44 pushed a commit to aswinashok44/gemini-cli that referenced this pull request Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants