-
Notifications
You must be signed in to change notification settings - Fork 11.7k
perf(cli): truncate large debug logs and limit message history #18663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3501163
perf: limit debug console message history and truncate large logs
mattKorwel c76ace1
perf: move truncation to UI hook to preserve full logs in files
mattKorwel e453167
Merge branch 'main' into fix/debug-log-memory
mattKorwel 4d8bed3
Merge branch 'main' into fix/debug-log-memory
mattKorwel a027782
Merge branch 'main' into fix/debug-log-memory
mattKorwel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,6 +31,7 @@ function consoleMessagesReducer( | |
| state: ConsoleMessageItem[], | ||
| action: Action, | ||
| ): ConsoleMessageItem[] { | ||
| const MAX_CONSOLE_MESSAGES = 1000; | ||
| switch (action.type) { | ||
| case 'ADD_MESSAGES': { | ||
| const newMessages = [...state]; | ||
|
|
@@ -51,6 +52,12 @@ function consoleMessagesReducer( | |
| newMessages.push({ ...queuedMessage, count: 1 }); | ||
| } | ||
| } | ||
|
|
||
| // Limit the number of messages to prevent memory issues | ||
| if (newMessages.length > MAX_CONSOLE_MESSAGES) { | ||
| return newMessages.slice(newMessages.length - MAX_CONSOLE_MESSAGES); | ||
| } | ||
|
|
||
| return newMessages; | ||
| } | ||
| case 'CLEAR': | ||
|
|
@@ -91,9 +98,17 @@ export function useConsoleMessages(): UseConsoleMessagesReturn { | |
|
|
||
| useEffect(() => { | ||
| const handleConsoleLog = (payload: ConsoleLogPayload) => { | ||
| let content = payload.content; | ||
| const MAX_CONSOLE_MSG_LENGTH = 10000; | ||
| if (content.length > MAX_CONSOLE_MSG_LENGTH) { | ||
| content = | ||
| content.slice(0, MAX_CONSOLE_MSG_LENGTH) + | ||
| `... [Truncated ${content.length - MAX_CONSOLE_MSG_LENGTH} characters]`; | ||
| } | ||
|
|
||
| handleNewMessage({ | ||
| type: payload.type, | ||
| content: payload.content, | ||
| content, | ||
| count: 1, | ||
| }); | ||
| }; | ||
|
|
@@ -102,10 +117,18 @@ export function useConsoleMessages(): UseConsoleMessagesReturn { | |
| isStderr: boolean; | ||
| chunk: Uint8Array | string; | ||
| }) => { | ||
| const content = | ||
| let content = | ||
| typeof payload.chunk === 'string' | ||
| ? payload.chunk | ||
| : new TextDecoder().decode(payload.chunk); | ||
|
|
||
| const MAX_OUTPUT_CHUNK_LENGTH = 10000; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: add a helper for this string truncation logic |
||
| if (content.length > MAX_OUTPUT_CHUNK_LENGTH) { | ||
| content = | ||
| content.slice(0, MAX_OUTPUT_CHUNK_LENGTH) + | ||
| `... [Truncated ${content.length - MAX_OUTPUT_CHUNK_LENGTH} characters]`; | ||
| } | ||
|
|
||
| // It would be nice if we could show stderr as 'warn' but unfortunately | ||
| // we log non warning info to stderr before the app starts so that would | ||
| // be misleading. | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: move const to the top level.