test: fix hook integration test flakiness on Windows CI

[NTaylorMullen]

test: robust fixes for windows hook flakiness

This PR addresses multiple sources of flakiness and failure in the hook system integration tests on Windows.

Fixes

1. Telemetry Leakage / Accumulating Failures:

   • Issue: Test retries were reusing the same test directory (derived from globalSetup timestamp), causing readToolLogs to pick up telemetry from previous failed attempts. This led to assertions seeing 1, then 2, then 3 tool calls instead of 0.
   • Fix: Updated TestRig.setup to aggressively clean up the test directory before starting a test run.

2. Process Spawning Failures (posix_spawnp):

   • Issue: Interactive tests using node-pty failed with posix_spawnp failed on Windows. This is often due to the PTY process missing critical environment variables like SystemRoot or COMSPEC.
   • Fix: Updated TestRig to explicitly include SystemRoot, COMSPEC, windir, and PATHEXT in the PTY environment options on Windows.

3. Disabled Hook Matching:

   • Issue: The 'Hook Disabling' test failed because the disabled hook path in the settings (using backslashes on Windows) didn't match the normalized hook command path (using forward slashes) used by the runner.
   • Fix: Updated the test to use normalizePath for the disabled list configuration, ensuring consistent path matching.

4. General Flakiness & Timeouts:

   • Fix: Increased Vitest timeout to 10 minutes for Windows.
   • Fix: Enforced sequential: true for all hook definitions in tests to prevent race conditions and ensure clean telemetry isolation.
   • Fix: Standardized on normalizePath helper for all path assertions to avoid fragile manual string replacement.

Validation

• Created a reproduction branch ntm/repro-hook-flakiness with a trimmed-down CI workflow to verify these fixes specifically on Windows.
• Local tests pass.

[gemini-code-assist]

Warning

Gemini encountered an error creating the summary. You can try again by commenting /gemini summary.

[github-actions]

Size Change: -73 B (0%)

Total Size: 24.4 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	24.4 MB	-73 B (0%)
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B
./bundle/sandbox-macos-strict-open.sb	4.82 kB	0 B
./bundle/sandbox-macos-strict-proxied.sb	5.02 kB	0 B

_{compressed-size-action}