fix(patch): cherry-pick 37f128a to release/v0.27.3-pr-18478 [CONFLICTS]#18743
Conversation
# Conflicts: # packages/core/src/routing/strategies/classifierStrategy.test.ts # packages/core/src/routing/strategies/numericalClassifierStrategy.test.ts # packages/core/src/routing/strategies/numericalClassifierStrategy.ts
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated cherry-pick to integrate a feature that restricts numerical routing to only Gemini 3 models into a patch release. The core change introduces a mechanism to identify Gemini 3 models and modifies existing routing strategies to leverage this identification, ensuring that numerical classification is applied appropriately. Due to conflicts arising during the automated cherry-pick process, manual intervention is required to resolve these discrepancies before the patch can be fully integrated. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request cherry-picks a feature to restrict numerical routing to the Gemini 3 model family. The logic changes in classifierStrategy.ts and numericalClassifierStrategy.ts correctly implement this restriction, and the new tests in models.test.ts and the strategy test files validate the new isGemini3Model function and routing behavior. However, the manual conflict resolution appears to be incomplete, as there are several files with leftover merge conflict markers. These are critical issues that must be resolved before merging.
packages/core/src/routing/strategies/classifierStrategy.test.ts
Outdated
Show resolved
Hide resolved
packages/core/src/routing/strategies/numericalClassifierStrategy.test.ts
Outdated
Show resolved
Hide resolved
packages/core/src/routing/strategies/numericalClassifierStrategy.ts
Outdated
Show resolved
Hide resolved
|
Size Change: +595 B (0%) Total Size: 23.5 MB ℹ️ View Unchanged
|
mattKorwel
left a comment
There was a problem hiding this comment.
Tested and working. Approved.
|
Support and proses earnings |
This PR automatically cherry-picks commit 37f128a to patch version v0.27.3 in the stable release to create version 0.27.4.
This cherry-pick resulted in merge conflicts that need manual resolution.
🔧 Next Steps:
📋 Files with conflicts:
The commit has been created with conflict markers for easier manual resolution.
🚨 Important: