fix(cli): allow closing debug console after auto-open via flicker#18795
fix(cli): allow closing debug console after auto-open via flicker#18795SandyTao520 merged 1 commit intomainfrom
Conversation
|
Hi @SandyTao520, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello @SandyTao520, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a regression that prevented users from closing the debug console after it was automatically opened. The core issue stemmed from inconsistent state toggling when activating DevTools via F12. The solution involves centralizing the DevTools panel activation and deactivation logic into a dedicated, well-tested utility function, ensuring that the UI state correctly reflects the panel's visibility across all possible outcomes. This improves the reliability and user experience of the DevTools integration. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively fixes a bug where the debug console could not be closed after being automatically opened. The logic has been cleanly refactored from AppContainer.tsx into a new, testable toggleDevToolsPanel function in devtoolsService.ts, and the new function is well-covered by unit tests. I have one suggestion to further improve the maintainability of the new function by reducing some code duplication.
|
Size Change: +17 B (0%) Total Size: 24.3 MB ℹ️ View Unchanged
|
488c71c to
6129e07
Compare

Summary
showErrorDetailson the success path — so the debug console couldn't be closed once flicker auto-opened it.toggleDevToolsPanel()function indevtoolsService.tsand ensures all code paths call the toggle/setOpen callback.Details
The original inline handler in
AppContainer.tsxhad three branches whendevtoolswas enabled:shouldLaunchBrowser()is false → toggleNow all three paths correctly invoke the callback. The logic is extracted into
toggleDevToolsPanel()with full test coverage.Related Issues
Closes the regression introduced by f5b1245 (#18695).
How to Validate
devtools: truein settingsnpx vitest run packages/cli/src/utils/devtoolsService.test.ts— all 18 tests pass including the 4 newtoggleDevToolsPaneltestsPre-Merge Checklist