fix(patch): cherry-pick 37f128a to release/v0.28.0-pr-18478#18821
Conversation
… [CONFLICTS] (#18732) Co-authored-by: matt korwel <matt.korwel@gmail.com>
# Conflicts: # packages/core/src/routing/strategies/classifierStrategy.test.ts # packages/core/src/routing/strategies/numericalClassifierStrategy.test.ts # packages/core/src/routing/strategies/numericalClassifierStrategy.ts
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the model routing mechanism by introducing a specific check for Gemini 3 models. The core intent is to ensure that the numerical routing strategy, which dynamically selects models, is only engaged when a Gemini 3 model is in use. This change enhances the precision of model selection and prevents unintended routing behavior with other model families, thereby improving the overall stability and predictability of the routing system. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request cherry-picks a feature to restrict numerical routing to Gemini 3 models. The changes look mostly correct, but there are several critical issues. Multiple files contain unresolved merge conflict markers which will break the build. I've provided suggestions to resolve them. Additionally, I've found a logic bug in the new isGemini3Model function and its usage, which doesn't correctly handle model aliases with preview features enabled. I've included suggestions to fix this bug and the related tests.
packages/core/src/routing/strategies/classifierStrategy.test.ts
Outdated
Show resolved
Hide resolved
packages/core/src/routing/strategies/numericalClassifierStrategy.test.ts
Outdated
Show resolved
Hide resolved
packages/core/src/routing/strategies/numericalClassifierStrategy.ts
Outdated
Show resolved
Hide resolved
packages/core/src/routing/strategies/numericalClassifierStrategy.ts
Outdated
Show resolved
Hide resolved
45688f4 to
3b3f7d7
Compare
|
Size Change: +465 B (0%) Total Size: 23.7 MB ℹ️ View Unchanged
|
mattKorwel
left a comment
There was a problem hiding this comment.
Tested locally and approved.
This PR automatically cherry-picks commit 37f128a to patch version v0.28.0 in the stable release to create version 0.28.1.
This cherry-pick resulted in merge conflicts that need manual resolution.
🔧 Next Steps:
📋 Files with conflicts:
The commit has been created with conflict markers for easier manual resolution.
🚨 Important: