feat(devtools): migrate devtools package into monorepo#18936
feat(devtools): migrate devtools package into monorepo#18936SandyTao520 merged 13 commits intomainfrom
Conversation
|
Hi @SandyTao520, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello @SandyTao520, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the DevTools functionality directly into the project's monorepo, enhancing maintainability and consistency. It refactors the DevTools into a dedicated workspace package, streamlining its build and dependency management. Crucially, it resolves existing UI issues within the DevTools, specifically improving how large JSON responses and chunked data streams are handled and displayed, leading to a more robust and reliable debugging experience. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Size Change: -41 B (0%) Total Size: 24.5 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
This pull request successfully migrates the gemini-cli-devtools package into the monorepo, which is a great step for maintainability. The migration of dependencies and paths seems correct. I've found a critical syntax error in the new devtools server that would prevent it from running, and a high-severity bug in the SSE parsing logic within the new React UI. Please see my comments for details and suggestions.
…ref heartbeat, keep devtools external in esbuild
…oid double-parse in export sort
Summary
Migrates the
gemini-cli-devtoolspackage source code into the monorepo atpackages/devtools/, replacing the external npm dependency with a workspace package (@google/gemini-cli-devtools).Also fixes two DevTools UI bugs:
RangeError: Invalid string lengthwhen serializing SSE snapshot — chunks are now dropped onceresponse.bodyarrives, eliminating data duplicationDetails
packages/devtools/with server (HTTP + WebSocket + SSE), React client UI, and custom build (esbuild for client + tsc for server)gemini-cli-devtoolsfrom rootoptionalDependenciesgemini-cli-devtools→@google/gemini-cli-devtools(esbuild external, devtoolsService, test mock)react-domto root devDependencies (needed for client build)client/index.htmlat runtime via__dirname)Related to #18648 #18494
How to Validate
npm install && npm run build— full build succeedsnpm run build --workspace=@google/gemini-cli-devtools— devtools builds independentlyls packages/devtools/dist/— should containsrc/index.js,src/index.d.ts,client/main.jsgeneral.devtools: truein settings → DevTools starts and serves UInpm run test --workspace=@google/gemini-cli— all tests pass (including devtoolsService tests)Pre-Merge Checklist