Skip to content

fix: character truncation in raw markdown mode#18938

Merged
jackwotherspoon merged 5 commits intomainfrom
fix/raw-markdown
Feb 12, 2026
Merged

fix: character truncation in raw markdown mode#18938
jackwotherspoon merged 5 commits intomainfrom
fix/raw-markdown

Conversation

@jackwotherspoon
Copy link
Contributor

Summary

  • Fix raw markdown mode (option+m) truncating 1-2 characters at the right edge of each line
  • Subtract the 2-character prefix width () from terminalWidth before passing it to MarkdownDisplay in both GeminiMessage and GeminiMessageContent

Problem

When toggling raw markdown mode, text at the right edge of the terminal gets truncated (e.g., "remaining" becomes "remaini"). This happens because MarkdownDisplay receives the full terminalWidth but the parent layout already reserves 2 characters for the prefix. Raw markdown mode then calculates maxWidth = terminalWidth - 1 (for code block padding), but only terminalWidth - 2 characters are actually available, causing overflow and truncation.

Rendered markdown is unaffected because <Text wrap="wrap"> respects the flex container's actual width. Raw markdown mode uses an explicit width={maxWidth} on a Box, which overflows the container.

Changes

  • GeminiMessage.tsx — pass terminalWidth - prefixWidth instead of terminalWidth to MarkdownDisplay
  • GeminiMessageContent.tsx — same fix

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@jackwotherspoon jackwotherspoon requested a review from a team as a code owner February 12, 2026 18:41
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Feb 12, 2026

Hi @jackwotherspoon, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jackwotherspoon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a visual bug in the raw markdown display mode where text was being cut off at the right edge of the terminal. The fix ensures that the available width for rendering markdown content correctly accounts for a fixed-width prefix, preventing truncation and improving the readability of raw markdown output.

Highlights

  • Bug Fix: Resolved an issue where raw markdown mode (option+m) truncated 1-2 characters at the right edge of each line in the terminal display.
  • Display Logic Adjustment: Modified the terminalWidth calculation in GeminiMessage and GeminiMessageContent to subtract the 2-character prefix width () before passing it to the MarkdownDisplay component.
Changelog
  • packages/cli/src/ui/components/messages/GeminiMessage.tsx
    • Adjusted the terminalWidth prop passed to MarkdownDisplay to correctly account for the prefix width.
  • packages/cli/src/ui/components/messages/GeminiMessageContent.tsx
    • Modified the terminalWidth prop passed to MarkdownDisplay to subtract the prefix width.
Activity
  • The author, jackwotherspoon, validated the changes on MacOS.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Feb 12, 2026

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding Fixes #123 or Related to #123), it will be automatically reopened.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details on supported keywords and how linking works, please refer to the GitHub Documentation on linking pull requests to issues.

Thank you for your understanding and for being a part of our community!

@gemini-cli gemini-cli bot closed this Feb 12, 2026
Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a snapshot test to verify the new behavior is good. Give it an example with an 80 char line or something to verify that truncation happens at the right points.lgtm

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a character truncation issue in raw markdown mode by accounting for the prefix width when calculating the available terminal width. The included review comments suggest clamping the calculated width to a minimum of zero, which prevents potential rendering issues or crashes in the edge case of a very narrow terminal window, thereby improving the robustness of the fix.

@github-actions
Copy link

github-actions bot commented Feb 12, 2026

Size Change: +82 B (0%)

Total Size: 24.3 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 24.3 MB +82 B (0%)
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B

compressed-size-action

@gemini-cli gemini-cli bot added the status/need-issue Pull requests that need to have an associated issue. label Feb 12, 2026
@jackwotherspoon jackwotherspoon added this pull request to the merge queue Feb 12, 2026
Merged via the queue into main with commit b0cfbc6 Feb 12, 2026
27 checks passed
@jackwotherspoon jackwotherspoon deleted the fix/raw-markdown branch February 12, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants