bug(cli) fix flicker due to AppContainer continuous initialization#18958
bug(cli) fix flicker due to AppContainer continuous initialization#18958
Conversation
|
Hi @jacob314, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello @jacob314, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a flickering issue within the application by eliminating an unnecessary re-initialization of the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request fixes a UI flicker issue that occurred on terminal resize. The root cause was correctly identified as the AppContainer component being re-mounted due to a changing key prop derived from the terminal dimensions. The fix removes this logic, preventing the re-mount and resolving the flicker. A regression test has been added to ensure AppContainer does not unmount on resize. I've provided a suggestion to improve the new test to more accurately simulate a terminal resize, making it a more robust regression guard.
|
Size Change: -87 B (0%) Total Size: 24.4 MB ℹ️ View Unchanged
|
…ntainer to be repeatedly initialized.
c90dd54 to
b62030b
Compare
|
@jacob314 I've updated the main repository and I'm testing it, and I think this fix messed up Gemini CLI. The terminal flickers occasionally, not always, but it's really annoying... |
Summary
Related Issues
Fixes #18956
Will follow up with a regression test but Gemini struggled to create a proper one so reverted what it added as too much was mocked.