-
Notifications
You must be signed in to change notification settings - Fork 11.7k
feat(core): experimental in-progress steering hints (1 of 3) #19008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,381
−60
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| /** | ||
| * @license | ||
| * Copyright 2026 Google LLC | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| import { AppRig } from '../packages/cli/src/test-utils/AppRig.js'; | ||
| import { | ||
| type EvalPolicy, | ||
| runEval, | ||
| prepareLogDir, | ||
| symlinkNodeModules, | ||
| } from './test-helper.js'; | ||
| import fs from 'node:fs'; | ||
| import path from 'node:path'; | ||
| import { DEFAULT_GEMINI_MODEL } from '@google/gemini-cli-core'; | ||
|
|
||
| export interface AppEvalCase { | ||
| name: string; | ||
| configOverrides?: any; | ||
| prompt: string; | ||
| timeout?: number; | ||
| files?: Record<string, string>; | ||
| setup?: (rig: AppRig) => Promise<void>; | ||
| assert: (rig: AppRig, output: string) => Promise<void>; | ||
| } | ||
|
|
||
| /** | ||
| * A helper for running behavioral evaluations using the in-process AppRig. | ||
| * This matches the API of evalTest in test-helper.ts as closely as possible. | ||
| */ | ||
| export function appEvalTest(policy: EvalPolicy, evalCase: AppEvalCase) { | ||
joshualitt marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| const fn = async () => { | ||
| const rig = new AppRig({ | ||
| configOverrides: { | ||
| model: DEFAULT_GEMINI_MODEL, | ||
| ...evalCase.configOverrides, | ||
| }, | ||
| }); | ||
|
|
||
| const { logDir, sanitizedName } = await prepareLogDir(evalCase.name); | ||
| const logFile = path.join(logDir, `${sanitizedName}.log`); | ||
|
|
||
| try { | ||
| await rig.initialize(); | ||
|
|
||
| const testDir = rig.getTestDir(); | ||
| symlinkNodeModules(testDir); | ||
|
|
||
| // Setup initial files | ||
| if (evalCase.files) { | ||
| for (const [filePath, content] of Object.entries(evalCase.files)) { | ||
| const fullPath = path.join(testDir, filePath); | ||
| fs.mkdirSync(path.dirname(fullPath), { recursive: true }); | ||
| fs.writeFileSync(fullPath, content); | ||
| } | ||
| } | ||
|
|
||
| // Run custom setup if provided (e.g. for breakpoints) | ||
| if (evalCase.setup) { | ||
| await evalCase.setup(rig); | ||
| } | ||
|
|
||
| // Render the app! | ||
| rig.render(); | ||
|
|
||
| // Wait for initial ready state | ||
| await rig.waitForIdle(); | ||
|
|
||
| // Send the initial prompt | ||
| await rig.sendMessage(evalCase.prompt); | ||
|
|
||
| // Run assertion. Interaction-heavy tests can do their own waiting/steering here. | ||
| const output = rig.getStaticOutput(); | ||
| await evalCase.assert(rig, output); | ||
| } finally { | ||
| const output = rig.getStaticOutput(); | ||
| if (output) { | ||
| await fs.promises.writeFile(logFile, output); | ||
| } | ||
| await rig.unmount(); | ||
| } | ||
| }; | ||
|
|
||
| runEval(policy, evalCase.name, fn, (evalCase.timeout ?? 60000) + 10000); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| /** | ||
| * @license | ||
| * Copyright 2026 Google LLC | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| import { describe, it, afterEach } from 'vitest'; | ||
| import { AppRig } from './AppRig.js'; | ||
| import path from 'node:path'; | ||
| import { fileURLToPath } from 'node:url'; | ||
|
|
||
| const __dirname = path.dirname(fileURLToPath(import.meta.url)); | ||
|
|
||
| describe('AppRig', () => { | ||
| let rig: AppRig | undefined; | ||
|
|
||
| afterEach(async () => { | ||
| await rig?.unmount(); | ||
| }); | ||
|
|
||
| it('should render the app and handle a simple message', async () => { | ||
| const fakeResponsesPath = path.join( | ||
| __dirname, | ||
| 'fixtures', | ||
| 'simple.responses', | ||
| ); | ||
| rig = new AppRig({ fakeResponsesPath }); | ||
| await rig.initialize(); | ||
| rig.render(); | ||
|
|
||
| // Wait for initial render | ||
| await rig.waitForIdle(); | ||
|
|
||
| // Type a message | ||
| await rig.type('Hello'); | ||
| await rig.pressEnter(); | ||
|
|
||
| // Wait for model response | ||
| await rig.waitForOutput('Hello! How can I help you today?'); | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.