feat(sdk): implement support for custom skills#19031
Conversation
- added skillDir and skillRoot helpers for referencing filesystem skills - implemented skill loading and registration in GeminiCliAgent - added addSkills to SkillManager in core to support programmatic skill addition - updated SDK integration tests to verify skill activation - marked custom skills as implemented in SDK_DESIGN.md
|
Hi @mbleigh, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello @mbleigh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the SDK by introducing a robust mechanism for custom skills. It allows developers to easily extend the agent's capabilities by defining and loading skills directly from the filesystem, using either individual skill directories or root directories containing multiple skills. This change empowers users to tailor the agent's behavior and integrate custom functionalities seamlessly, making the SDK more flexible and adaptable to diverse use cases. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Size Change: +225 B (0%) Total Size: 24.4 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
This pull request implements support for custom skills in the SDK, introducing skillDir and skillRoot helpers for loading skills from the filesystem and integrating them into the GeminiCliAgent. Consider improving skill loading performance by parallelizing file system operations to optimize SDK initialization time.
Summary
This PR implements support for custom skills in the SDK, allowing developers to load and register skills from the filesystem using
skillDirandskillRoothelpers.Details
skillDirandskillRoothelpers inpackages/sdk/src/skills.tsfor referencing filesystem skills.GeminiCliAgent(packages/sdk/src/agent.ts).addSkillsmethod toSkillManagerinpackages/coreto support programmatic skill addition.SDK_DESIGN.mdto reflect the implementation status of Custom Skills.packages/sdk/src/skills.integration.test.tsto verify skill activation from both single directory and root directory sources.Related Issues
How to Validate
Run the SDK integration tests:
npm test -w packages/sdk -- skills.integration.test.tsPre-Merge Checklist