Skip to content

fix(cli): wrap terminal capability queries in hidden sequence#19080

Merged
srithreepo merged 4 commits intomainfrom
fix/terminal-query-visibility
Feb 15, 2026
Merged

fix(cli): wrap terminal capability queries in hidden sequence#19080
srithreepo merged 4 commits intomainfrom
fix/terminal-query-visibility

Conversation

@srithreepo
Copy link
Contributor

@srithreepo srithreepo commented Feb 14, 2026

Summary

Wrap terminal capability queries in a hidden mode sequence and clear the line afterwards to prevent a stray "m" character from appearing on some terminals (e.g., Apple Terminal, some tmux versions) during startup.

Details

When the CLI starts, it queries the terminal for various capabilities (Kitty protocol, background color, etc.). Some terminals might echo part of the response or malform it such that a stray "m" remains on the command line. By wrapping these queries in \x1b[8m (hidden mode) and following up with \x1b[2K (clear line and return) and \x1b[0m (reset attributes), we ensure any echoed or malformed output is not visible to the user.

Related Issues

Fixes #19081

None.

How to Validate

  1. Run the project in a terminal that was previously showing the stray "m".
  2. Observe that the "m" no longer appears during startup.
  3. Run unit tests: npm test -w @google/gemini-cli -- src/ui/utils/terminalCapabilityManager.test.ts.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed) - Not needed
  • Added/updated tests (if needed)
  • Noted breaking changes (if any) - None
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
    • Linux

@srithreepo srithreepo requested a review from a team as a code owner February 14, 2026 19:29
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Feb 14, 2026

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding Fixes #123 or Related to #123), it will be automatically reopened.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details on supported keywords and how linking works, please refer to the GitHub Documentation on linking pull requests to issues.

Thank you for your understanding and for being a part of our community!

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Feb 14, 2026

Hi @srithreepo, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@gemini-cli gemini-cli bot closed this Feb 14, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @srithreepo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user experience of the CLI by addressing a visual artifact that could appear during startup on specific terminal emulators. By strategically applying ANSI escape codes, the CLI now gracefully handles terminal capability queries, ensuring a clean and uninterrupted display for users.

Highlights

  • Terminal Output Glitch Fix: Implemented a fix to prevent a stray "m" character from appearing on some terminals (e.g., Apple Terminal, certain tmux versions) during CLI startup.
  • Hidden Mode for Terminal Queries: Wrapped terminal capability queries in ANSI escape sequences (\x1b[8m for hidden mode, \x1b[2K\r to clear line and return, \x1b[0m to reset attributes) to hide the output and prevent malformed responses from being visible.
  • Test Coverage: Added a new unit test to verify that terminal capability queries are correctly wrapped in the hidden/clear sequences.
Changelog
  • packages/cli/src/ui/utils/terminalCapabilityManager.test.ts
    • Imported the node:fs module.
    • Added a new test case to assert that fs.writeSync is called with the correct hidden and clear sequences.
  • packages/cli/src/ui/utils/terminalCapabilityManager.ts
    • Modified the fs.writeSync call to prepend \x1b[8m (hidden mode) and append \x1b[2K\r\x1b[0m (clear line, carriage return, reset attributes) to the terminal capability queries.
    • Added comments explaining the purpose of the new ANSI escape sequences.
Activity
  • The author has completed pre-merge checklist items, including adding/updating tests and validating on MacOS.
  • No breaking changes were noted.
  • No documentation updates were deemed necessary.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively resolves the issue of a stray character appearing in certain terminals during startup by wrapping capability queries in a hidden mode sequence. The implementation is solid and the addition of a test case is appreciated. I have one high-severity suggestion to improve the new test, making it more specific to ensure the atomicity of the write operation and prevent potential future regressions, which aligns with our guidelines for atomic fs.writeSync operations.

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Feb 14, 2026

Thank you for linking an issue! This pull request has been automatically reopened.

@gemini-cli gemini-cli bot reopened this Feb 14, 2026
@github-actions
Copy link

github-actions bot commented Feb 14, 2026

Size Change: +629 B (0%)

Total Size: 24.4 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 24.4 MB +629 B (0%)
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B

compressed-size-action

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@gemini-cli gemini-cli bot added the area/core Issues related to User Interface, OS Support, Core Functionality label Feb 14, 2026
@srithreepo srithreepo added this pull request to the merge queue Feb 15, 2026
Merged via the queue into main with commit 78130d4 Feb 15, 2026
27 checks passed
@srithreepo srithreepo deleted the fix/terminal-query-visibility branch February 15, 2026 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(cli): stray 'm' character printed during terminal startup

3 participants