fix(cli): wrap terminal capability queries in hidden sequence#19080
fix(cli): wrap terminal capability queries in hidden sequence#19080srithreepo merged 4 commits intomainfrom
Conversation
|
Hi there! Thank you for your contribution to Gemini CLI. To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md. This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding How to link an issue: Thank you for your understanding and for being a part of our community! |
|
Hi @srithreepo, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello @srithreepo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the user experience of the CLI by addressing a visual artifact that could appear during startup on specific terminal emulators. By strategically applying ANSI escape codes, the CLI now gracefully handles terminal capability queries, ensuring a clean and uninterrupted display for users. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively resolves the issue of a stray character appearing in certain terminals during startup by wrapping capability queries in a hidden mode sequence. The implementation is solid and the addition of a test case is appreciated. I have one high-severity suggestion to improve the new test, making it more specific to ensure the atomicity of the write operation and prevent potential future regressions, which aligns with our guidelines for atomic fs.writeSync operations.
|
Thank you for linking an issue! This pull request has been automatically reopened. |
|
Size Change: +629 B (0%) Total Size: 24.4 MB ℹ️ View Unchanged
|
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Summary
Wrap terminal capability queries in a hidden mode sequence and clear the line afterwards to prevent a stray "m" character from appearing on some terminals (e.g., Apple Terminal, some tmux versions) during startup.
Details
When the CLI starts, it queries the terminal for various capabilities (Kitty protocol, background color, etc.). Some terminals might echo part of the response or malform it such that a stray "m" remains on the command line. By wrapping these queries in
\x1b[8m(hidden mode) and following up with\x1b[2K(clear line and return) and\x1b[0m(reset attributes), we ensure any echoed or malformed output is not visible to the user.Related Issues
Fixes #19081
None.
How to Validate
npm test -w @google/gemini-cli -- src/ui/utils/terminalCapabilityManager.test.ts.Pre-Merge Checklist