feat(cli): add loading state to new agents notification

[sehoon38]

Summary

This PR adds a loading state to the NewAgentsNotification component to provide visual feedback when a user selects an option. Previously, there was a delay while agents were being acknowledged, leading to a perception that nothing was happening.

Details

• Added isProcessing state to NewAgentsNotification.
• Integrated CliSpinner to show a "Processing..." message upon selection.
• Updated onSelect prop type to support Promise<void>.
• Added unit tests to verify the processing state is displayed.

Related Issues

Fixes #19191

How to Validate

1. Run the CLI in a project where new agents are discovered.
2. Select "Acknowledge and Enable".
3. Observe the "Processing..." spinner appearing before the dialog closes.
4. Run tests: npm test -w @google/gemini-cli -t NewAgentsNotification

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run

[gemini-cli]

Hi @sehoon38, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

[gemini-cli]

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding Fixes #123 or Related to #123), it will be automatically reopened.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details on supported keywords and how linking works, please refer to the GitHub Documentation on linking pull requests to issues.

Thank you for your understanding and for being a part of our community!

[gemini-code-assist]

Summary of Changes

Hello @sehoon38, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user experience of the CLI's new agents notification by introducing a visual loading indicator. Previously, users experienced a delay without feedback after making a selection, which could lead to confusion. The addition of a "Processing..." spinner now clearly communicates that an action is underway, improving the perceived responsiveness of the application.

Highlights

• Loading State: Introduced a loading state to the NewAgentsNotification component to provide visual feedback during processing.
• Spinner Integration: Integrated CliSpinner to display a "Processing..." message when an option is selected.
• Asynchronous Selection: Updated the onSelect prop type to support asynchronous operations (Promise<void>).
• Unit Tests: Added new unit tests to ensure the processing state is correctly displayed.

Changelog

• packages/cli/src/ui/components/NewAgentsNotification.test.tsx
  • Imported waitFor and act for asynchronous testing.
  • Added a new test case to verify that the "Processing..." message appears when an option is selected and onSelect is an async function.
• packages/cli/src/ui/components/NewAgentsNotification.tsx
  • Imported useState hook and CliSpinner component.
  • Modified the onSelect prop type to accept void | Promise<void>.
  • Introduced an isProcessing state variable to manage the loading indicator.
  • Created an async handleSelect function that sets isProcessing to true before calling the onSelect prop.
  • Conditionally rendered either the CliSpinner with a "Processing..." message or the RadioButtonSelect based on the isProcessing state.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a loading state to the NewAgentsNotification component, which is a valuable user experience enhancement. The implementation is sound, and the identified potential issue with state management has been addressed. The suggestion to use a try...finally block ensures the loading state is always reset, making the component's state handling more robust.

[github-actions]

Size Change: +611 B (0%)

Total Size: 24.4 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	24.4 MB	+611 B (0%)
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B
./bundle/sandbox-macos-strict-open.sb	4.82 kB	0 B
./bundle/sandbox-macos-strict-proxied.sb	5.02 kB	0 B

_{compressed-size-action}