refactor: consolidate development rules and add cli guidelines

[jacob314]

Summary

Reduce duplicate logic
Add a
packages/cli/GEMINI.md file

All logic in strict-development-rules.md is existing except for the TUI best practices section, prohibition on custom text measurement, and prohibition on /no-floating-promises`

Fixes #19215

[gemini-code-assist]

Summary of Changes

Hello @jacob314, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the development guidelines for the CLI's React & Ink UI components by adding specific instructions to GEMINI.md. The aim is to standardize practices and prevent common issues related to UI rendering and state management, ensuring a more consistent and maintainable codebase for the command-line interface.

Highlights

• Updated Development Guidelines: The GEMINI.md file has been updated with new guidelines specifically for React & Ink (CLI UI) development.
• New UI Development Rules: New rules were added to prevent custom string measurement/truncation and to discourage prop drilling in Ink layouts, promoting better UI practices.

Changelog

• packages/cli/GEMINI.md
  • Added new guidelines for React & Ink (CLI UI) development.
  • Included rules to avoid custom string measurement/truncation.
  • Added a rule to avoid prop drilling.

Ignored Files

• Ignored by pattern: .gemini/** (5)
  • .gemini/commands/frontend.toml
  • .gemini/commands/full-context.toml
  • .gemini/commands/review-and-fix.toml
  • .gemini/commands/review-frontend.toml
  • .gemini/commands/strict-development-rules.md

Activity

• No specific activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request updates packages/cli/GEMINI.md with new development guidelines for React and Ink, specifically prohibiting custom string measurement or truncation in favor of Ink's layout engine and ResizeObserver, and advising against prop drilling. These additions align with best practices for the project's CLI UI. I noticed a minor regression in line 3 where an opening backtick was removed from setState, but as this is a documentation change, it falls below the high-severity threshold required for individual review comments. The mentioned refactor into strict-development-rules.md was not included in the provided patches.

[github-actions]

Size Change: -2 B (0%)

Total Size: 24.4 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	24.4 MB	-2 B (0%)
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B
./bundle/sandbox-macos-strict-open.sb	4.82 kB	0 B
./bundle/sandbox-macos-strict-proxied.sb	5.02 kB	0 B

_{compressed-size-action}

[anowardear062-svg]

Thanks